Enhance 'Find' context in Expression View #2276
Merged
+171
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@SougandhS also not directly related but can we maybe add an icon to the find menu item= it looks a bit misplaced as it is the only one without one. |
Contributor
Author
Sure, will add one 👍 |
Contributor
SougandhS
force-pushed
the
ShowFindExp
branch
from
8940a4f to
9be9970
Compare
Contributor
Author
|
Added find icon |
SougandhS
changed the title
SougandhS
force-pushed
the
ShowFindExp
branch
from
9be9970 to
8349b0e
Compare
Member
|
Not sure why didn't you also disable "Copy Expressions" for same reason? |
Contributor
Author
All the |
SougandhS
force-pushed
the
ShowFindExp
branch
4 times, most recently
from
43bf06f to
d42d76f
Compare
- Show only when there are active Expressions - Add an Icon
SougandhS
force-pushed
the
ShowFindExp
branch
from
d42d76f to
b7d323b
Compare
Contributor
Author
|
Hi @laeubi, could you please merge this too ? |
Contributor
Author
|
Thank you ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make 'Find' context in Expressions view appears only when valid expressions exist.
Before :
After :
