Improve quality of breakpoint enablement icon #2300
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Looks great now 👍, |
Contributor
The icon for breakpoint enablement is currently composed of three PNG images, which leads to blurry results when scaling it. There exist similar images (with the contained circles just colored differently) as properly vectorized SVGs. This change proposes a replacement of the breakpoint enablement icon which adapts the existing, fully vectorized icon for breakpoint groups.
HeikoKlare
force-pushed
the
icon-breakpoint-enablement-vectorize
branch
from
d1d6bbd to
3c521eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The icon for breakpoint enablement is currently composed of three PNG images, which leads to blurry results when scaling it. There exist similar images (with the contained circles just colored differently) as properly vectorized SVGs. As a side note: the blue tone does also not perfectly fit to the blue tone used in the other similar icons.
This change proposes a replacement of the breakpoint enablement icon which adapts the existing, fully vectorized icon for breakpoint groups.
@SougandhS the SVG was introduced with:
I guess it was just created like that by accident and not on purpose, was it? Could you please check whether the proposed replacement fits to how you wanted it to look like?
Screenshots
Appearance at 100% and 175%
Before
After