Add N & N for Compare/Replace from clipboard #378
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Hi @merks, could you please check this PR when you get some time ? |
merks
approved these changes
Jul 3, 2025
Contributor
merks
left a comment
merks
left a comment
There was a problem hiding this comment.
It would be better to clip out the whitespace from the png and clip down the compare "view" to show mostly only the meaningful content.
Otherwise it looks fine.
Contributor
Author
Done 👍 |
SougandhS
force-pushed
the
N&N_Compare
branch
2 times, most recently
from
25fe5a4 to
f9e9212
Compare
merks
reviewed
Jul 3, 2025
Contributor
merks
left a comment
merks
left a comment
There was a problem hiding this comment.
This is still kind of useless whitespace in the image itself:
And the other is like that too.
Contributor
Author
Understood, trimmed bit more 👍 |
Contributor
Author
|
Thank you @merks 😇 |
Contributor
|
Thanks @SougandhS for your work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
N&N for eclipse-platform/eclipse.platform#1862