Skip to content

Conversation

@github-actions
Copy link
Contributor

Update the list of contributors in the Acknowledgements for 4.37.

Adjustments to the lists of contributors:

Please verify these adjustments for correctness and grant those who are affected sufficient time to refine the adjustments.

@HannesWell
Copy link
Member

This was triggered by the last test run of

I actually expected it to not create a PR as there a no new contributors, but I forgot the Last revised field...
Technically it's correct to update it as the list was revised, but I think this causes unnecessary noise.
I can update the job to avoid updating only that date.
Or do you others think we should keep updating it?
Or is that field irrelevant any ways and we should remove it? I just added it back then because it was there before.

@akurtakov
Copy link
Member

IMO the commit date serves the same purpose and can probably be used for display purposes.

@github-actions github-actions bot force-pushed the acknowledgements_4.37 branch from cfbd7f2 to 6a35ef9 Compare August 22, 2025 07:31
@HannesWell
Copy link
Member

IMO the commit date serves the same purpose and can probably be used for display purposes.

Do you suggest to read it from the GH API dynamically and substitute it when rendering the markdown on the client-side?

@github-actions github-actions bot force-pushed the acknowledgements_4.37 branch from 6a35ef9 to 219fb35 Compare August 29, 2025 06:07
@HannesWell
Copy link
Member

IMO the commit date serves the same purpose and can probably be used for display purposes.

Do you suggest to read it from the GH API dynamically and substitute it when rendering the markdown on the client-side?

Will look into this later.
For now I'm closing this, to allow a new run of the job to (re-) generate the acknowledgements can start in a fresh PR.

@HannesWell HannesWell closed this Aug 29, 2025
@HannesWell HannesWell deleted the acknowledgements_4.37 branch August 29, 2025 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants