-
Notifications
You must be signed in to change notification settings - Fork 58
Add N&N entry for few filtering options in preference page #433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
0c00780 to
fa33d4a
Compare
|
@merks Could you check if this looks okay? |
286a571 to
f431661
Compare
news/4.38/platform.md
Outdated
|
|
||
| Filtering has now been introduced in more areas of the Preference page to make it easier to find and manage entries. | ||
|
|
||
| A filtering option is now available in the File Content section under the **Version Control (Team)** preferences, providing quick filtering of file specific extensions. In addition, filtering options have been added to the Templates sections under the **Java Editor**, **Ant Editor**, and **Template Editor**. This has also been added to the **Add to Favourites** dialog under Run/Debug launches, and also to the **Export Launch Configurations** dialog. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please break long sentences across multiple lines.
https://eclipse.dev/eclipse/markdown/?f=news/instructions.md
Generally text that refers literal to content in the IDE use Name not Name nor Name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I will repush the changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Forgot to mark it to request changes.
Are you actually previewing the content and comparing how it looks to existing content?
https://eclipse.dev/eclipse/markdown/?f=news/instructions.md#markdown-preview
054379b to
e563f44
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if you really intend every sentence to be a separate paragraph? Two sentences on separate lines without a blank line between then will become part of a single paragraph. It seems to me originally you had several sentences in one huge line to create paragraph. So I want to be sure you intended there to be so many paragraphs?
I wanted only 3 paragraphs initially, with the middle one being about the actual feature. |
afeaf3c to
f4ea788
Compare
news/4.38/platform.md
Outdated
|
|
||
| Filtering has now been introduced in more areas of the Preference page to make it easier to find and manage entries. | ||
|
|
||
| A filtering option is now available in the File Content section under the `Version Control (Team)` preferences, providing quick filtering of file specific extensions. In addition, filtering options have been added to the Templates sections under the `Java Editor`, `Ant Editor`, and `Template Editor`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you tried simply starting the second sentence on a new line without also adding a blank line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried that, but simply starting a sentence on a new line without a blank line entry doesn’t create a line break in the markdown preview. So, I added <br> to move to a new line without starting a new paragraph.
f4ea788 to
da2b38b
Compare
Added a N&N entry about the new filtering options available in Template and File Content preference pages.
da2b38b to
ad9110e
Compare
This PR adds N&N entry for PR's 3433, 2120, 2188 and 2118