[BUG] Scenario Parsing Error in Nodeagent(reciever.rs)#114
Merged
youngtaekiim merged 2 commits intoeclipse-pullpiri:refactoringfrom Jul 10, 2025
Merged
[BUG] Scenario Parsing Error in Nodeagent(reciever.rs)#114youngtaekiim merged 2 commits intoeclipse-pullpiri:refactoringfrom
youngtaekiim merged 2 commits intoeclipse-pullpiri:refactoringfrom
Conversation
desc : Scenario Parsing Error in Nodeagent(reciever.rs) Due to wrong workload_name(package) passed from apiserver(manager.rs) and etc.
youngtaekiim
reviewed
Jul 9, 2025
| @@ -27,6 +27,11 @@ spec: | |||
| resources: | |||
| volume: | |||
| network: | |||
Contributor
There was a problem hiding this comment.
discard change of this file (helloworld.yaml)
youngtaekiim
reviewed
Jul 9, 2025
| format!("{}:{}", crate::setting::get_config().host.ip, port) | ||
| } | ||
|
|
||
| fn open_guest_server(port: u16) -> String { |
Contributor
There was a problem hiding this comment.
There is not enough preparation for multi guest nodes. Now, keep going and modify later.
youngtaekiim
reviewed
Jul 9, 2025
|
|
||
| assert!(result.is_err()); | ||
| } | ||
| Ok(1) |
youngtaekiim
reviewed
Jul 9, 2025
|
|
||
| println!("Error: {}", response_inner.desc); | ||
| Ok(response_inner.status) | ||
| } |
Contributor
There was a problem hiding this comment.
do not remove test codes. it will have to be modified.
youngtaekiim
reviewed
Jul 9, 2025
| yaml: body.to_string(), | ||
| }; | ||
| crate::grpc::sender::nodeagent::send(workload_request).await?; | ||
|
|
Contributor
There was a problem hiding this comment.
move this block to first line of function apply_artifact.
And send_guest should not be called if there are no guest nodes.
youngtaekiim
reviewed
Jul 9, 2025
| let storage_dir = "/etc/piccolo/yaml"; | ||
| tokio::time::sleep(std::time::Duration::from_millis(1000)).await; | ||
| let result = make_files_from_pod(vec![pod.clone()]).await; | ||
| let result = make_files_from_pod(vec![pod.clone()], "HPC".to_string()).await; |
Contributor
There was a problem hiding this comment.
discard change in test code
youngtaekiim
reviewed
Jul 9, 2025
|
|
||
| Ok(()) | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
do not remove test codes
youngtaekiim
reviewed
Jul 9, 2025
|
|
||
| Ok(models) | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
do not remove test codes
youngtaekiim
requested changes
Jul 9, 2025
Contributor
youngtaekiim
left a comment
youngtaekiim
left a comment
There was a problem hiding this comment.
need to fix according to comments
youngtaekiim
merged commit 033117d
into
eclipse-pullpiri:refactoring
5 of 6 checks passed
6 tasks
chaehee-lim
pushed a commit
to chaehee-lim/pullpiri
that referenced
this pull request
Sep 3, 2025
[BUG] Scenario Parsing Error in Nodeagent(reciever.rs)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
url: #110
desc : Scenario Parsing Error in Nodeagent(reciever.rs) Due to wrong workload_name(package) passed from apiserver(manager.rs) and etc.