feat(api)-Update Metrics strucutre,Load ContainerInfo from ETCD and Define more REST APIs on SettingsService#282
Conversation
|
Hey @leeeunkoo @daeyoung-jeong-lge @youngtaekiim |
daeyoung-jeong-lge
left a comment
daeyoung-jeong-lge
left a comment
There was a problem hiding this comment.
Looks nice. But it would be better if you add contents related to ContainerInfo on src/server/settingsservice/board-soc-node-rest-api.md.
|
I updated the README.md for all restapis information
Thanks
…On Mon, 22 Sep 2025 at 5:05 AM, daeyoung.jeong_lge ***@***.***> wrote:
***@***.**** approved this pull request.
Looks nice. But it would be better if you add contents related to
ContainerInfo on src/server/settingsservice/board-soc-node-rest-api.md.
—
Reply to this email directly, view it on GitHub
<#282 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BRY6W2LPJNVLN52Y2Y2DHM33T4Y5DAVCNFSM6AAAAACG54QKXSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTENJQGIYDMOBVG4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
@leeeunkoo @youngtaekiim I finished my review. If you have no more comment for this PR, please merge this. Thanks. |
| .route("/api/v1/monitoring/sync", post(sync_with_monitoring_server)) | ||
| // Additional metrics routes | ||
| .route("/api/v1/metrics/nodes", get(get_all_node_metrics)) | ||
| .route("/api/v1/metrics/containers", get(get_all_container_metrics)) |
There was a problem hiding this comment.
I can't find "post" and "delete" for containers, not like board, soc, nodes.
There was a problem hiding this comment.
Hey @daeyoung-jeong-lge sorry for late reply, yesterday our team outing is there so i was not able to reply,
In this did you mean like nodesoc and board only post and delete func is needed for container also?
thanks!!
There was a problem hiding this comment.
@akshaylg0314 No problem! And Yes. I heard from Dashboard developer that we need post and delete func also for container.
|
@akshaylg0314 Could you give some help to @LGSI-KarumuriHari to get ContainerInfo on Dashboard? He is getting Board/Soc/NodeInfo, but not ContainerInfo in his environment. Thanks. |
Yes sure i will modify FOR POST AND DELETE also |
feat(api)-Update Metrics strucutre,Load ContainerInfo from ETCD and Define more REST APIs on SettingsService
3 participants
📝 PR Description
feat(api)-Update Metrics strucutre,Load ContainerInfo from ETCD and Define more REST APIs on SettingsService
1.Load ContainerInfo from ETCD at SettingsService
2.Define more REST APIs on SettingsService for Dashboard 3.Update Metrics strucutre on settingsservice for Matching with ETCD keys(Board/Soc/Node)
3.Update Metrics strucutre on settingsservice for Matching with ETCD keys(Board/Soc/Node)
🔗 Related Issue
closes-> #266,
#264
#274
🧪 Test Method
Documentation is also updated with testing methods and usage in README.md file
Updated in Readme File through curl commands.
✅ Checklist
[✅] Code conventions are followed
[✅] Tests are added/modified
[✅] Documentation is updated (if necessary)