Skip to content

feat(api)-Define more REST APIs DELETE POST on SettingsService for Dashboard[#264]#285

Merged
youngtaekiim merged 5 commits intoeclipse-pullpiri:mainfrom
akshaylg0314:main
Sep 24, 2025
Merged

feat(api)-Define more REST APIs DELETE POST on SettingsService for Dashboard[#264]#285
youngtaekiim merged 5 commits intoeclipse-pullpiri:mainfrom
akshaylg0314:main

Conversation

@akshaylg0314
Copy link
Contributor

📝 PR Description

feat(api)-Define more REST APIs DELETE POST on SettingsService for Dashboard[#264]

🔗 Related Issue
closes->
#264

🧪 Test Method
Documentation is also updated with testing methods and usage in README.md file

Updated in Readme File through curl commands.

✅ Checklist
[✅] Code conventions are followed
[✅] Tests are added/modified
[✅] Documentation is updated (if necessary)

@akshaylg0314
Copy link
Contributor Author

akshaylg0314 commented Sep 23, 2025

Hey @youngtaekiim @daeyoung-jeong-lge @leeeunkoo
Please review the code changes as per req for POST,DELETE Funcs for container.
My changes are in files:
modified: src/server/settingsservice/README.md
modified: src/server/settingsservice/src/settings_api/mod.rs
modified: src/server/settingsservice/src/settings_monitoring/mod.rs
modified: src/server/settingsservice/src/settings_utils/error.rs

Other are formatting changes
thanks!!

@akshaylg0314
Copy link
Contributor Author

akshaylg0314 commented Sep 23, 2025

Hey @youngtaekiim @daeyoung-jeong-lge @leeeunkoo
the CI check is failing at test due to below reason:
Running cargo test command on src/common:

error[E0609]: no field `guest` on type `Settings`
  --> src/setting.rs:97:40
   |
97 |         if let Some(guests) = settings.guest {
   |                                        ^^^^^ unknown field
   |
   = note: available fields are: `yaml_storage`, `piccolo_cloud`, `host`

error[E0609]: no field `guest` on type `Settings`
   --> src/setting.rs:166:40
    |
166 |         if let Some(guests) = settings.guest {
    |                                        ^^^^^ unknown field
    |
    = note: available fields are: `yaml_storage`, `piccolo_cloud`, `host`

error[E0609]: no field `guest` on type `Settings`
   --> src/setting.rs:179:40
    |
179 |         if let Some(guests) = settings.guest {
    |                                        ^^^^^ unknown field
    |
    = note: available fields are: `yaml_storage`, `piccolo_cloud`, `host`

error[E0609]: no field `guest` on type `Settings`
   --> src/setting.rs:191:40
    |
191 |         if let Some(guests) = settings.guest {
    |                                        ^^^^^ unknown field
    |
    = note: available fields are: `yaml_storage`, `piccolo_cloud`, `host`

For more information about this error, try `rustc --explain E0609`.
error: could not compile `common` (lib test) due to 4 previous errors

This came after merging clustering code i will update the Test cases also accordingly
thanks!!

Copy link
Contributor

@daeyoung-jeong-lge daeyoung-jeong-lge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't ask to add filtering, paging functionalities, but it's OK. Looks good.

@daeyoung-jeong-lge
Copy link
Contributor

@leeeunkoo @youngtaekiim I finished my review on this. If you have no comment, please merge this. Thanks.

@youngtaekiim youngtaekiim merged commit e48d9c8 into eclipse-pullpiri:main Sep 24, 2025
6 checks passed
@akshaylg0314
Copy link
Contributor Author

I haven't ask to add filtering, paging functionalities, but it's OK. Looks good.

Yes @daeyoung-jeong-lge i just added these extra apis and func because i thought it is required for dashboard in future.
Thanks!!

yeohyeon-i added a commit to yeohyeon-i/pullpiri that referenced this pull request Sep 25, 2025
feat(api)-Define more REST APIs DELETE POST on SettingsService for Dashboard[eclipse-pullpiri#264]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants