feat(api)-Define more REST APIs DELETE POST on SettingsService for Dashboard[#264]#285
Conversation
|
Hey @youngtaekiim @daeyoung-jeong-lge @leeeunkoo Other are formatting changes |
|
Hey @youngtaekiim @daeyoung-jeong-lge @leeeunkoo This came after merging clustering code i will update the Test cases also accordingly |
daeyoung-jeong-lge
left a comment
There was a problem hiding this comment.
I haven't ask to add filtering, paging functionalities, but it's OK. Looks good.
|
@leeeunkoo @youngtaekiim I finished my review on this. If you have no comment, please merge this. Thanks. |
Yes @daeyoung-jeong-lge i just added these extra apis and func because i thought it is required for dashboard in future. |
feat(api)-Define more REST APIs DELETE POST on SettingsService for Dashboard[eclipse-pullpiri#264]
📝 PR Description
feat(api)-Define more REST APIs DELETE POST on SettingsService for Dashboard[#264]
🔗 Related Issue
closes->
#264
🧪 Test Method
Documentation is also updated with testing methods and usage in README.md file
Updated in Readme File through curl commands.
✅ Checklist
[✅] Code conventions are followed
[✅] Tests are added/modified
[✅] Documentation is updated (if necessary)