feat(api)-Remove CLI functionality from SettingsService[#284]#291
Merged
youngtaekiim merged 1 commit intoeclipse-pullpiri:mainfrom Sep 24, 2025
Merged
feat(api)-Remove CLI functionality from SettingsService[#284]#291youngtaekiim merged 1 commit intoeclipse-pullpiri:mainfrom
youngtaekiim merged 1 commit intoeclipse-pullpiri:mainfrom
Conversation
Resolving Indentation error in MakeFile
Contributor
Author
|
Hey @daeyoung-jeong-lge @youngtaekiim @leeeunkoo |
Contributor
|
@leeeunkoo @youngtaekiim My review is done. Please merge this. Thanks. |
youngtaekiim
approved these changes
Sep 24, 2025
yeohyeon-i
added a commit
to yeohyeon-i/pullpiri
that referenced
this pull request
Sep 25, 2025
feat(api)-Remove CLI functionality from SettingsService[eclipse-pullpiri#284]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 PR Description
->feat(api)-Remove CLI functionality from SettingsService[#284]
->Resolving Indentation error in MakeFile
🔗 Related Issue
closes->
#284
🧪 Test Method
CLI For setting service not avaliable and test settingservice,Nodeagent and monitoringserver.
✅ Checklist
[✅] Code conventions are followed
[✅] Tests are added/modified
[✅] Documentation is updated (if necessary)