fix(dashboard): Update filter logic to use nodes as source [#294]#313
Merged
leeeunkoo merged 4 commits intoeclipse-pullpiri:mainfrom Sep 30, 2025
Merged
fix(dashboard): Update filter logic to use nodes as source [#294]#313leeeunkoo merged 4 commits intoeclipse-pullpiri:mainfrom
leeeunkoo merged 4 commits intoeclipse-pullpiri:mainfrom
Conversation
…/memory logic, update filter logic - Removed all mock node data from workloads dashboard - Added periodic fetch (every 5 seconds) for nodes to get latest updates - Improved pod age and memory usage calculation logic - Updated filter logic to use nodes as source, then map pods to nodes (nodes created first, pods assigned after)
Contributor
Author
|
Hey @daeyoung-jeong-lge @youngtaekiim @leeeunkoo |
Contributor
|
@chaehee-lim Could you review this PR? Thanks. |
Contributor
daeyoung-jeong-lge
left a comment
daeyoung-jeong-lge
left a comment
There was a problem hiding this comment.
@chaehee-lim Please check my review comments and give your opinion to Hari. Thanks.
Contributor
Author
|
@daeyoung-jeong-lge @chaehee-lim
|
Contributor
|
@chaehee-lim After review, please request to @leeeunkoo and @youngtaekiim to merge this PR. Thanks. |
Contributor
|
@leeeunkoo @youngtaekiim |
leeeunkoo
approved these changes
Sep 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 PR Description
This PR refactors the dashboard workloads logic to remove all mock node data and implements real-time node and pod updates. Nodes are now fetched from the backend API every 5 seconds, ensuring the dashboard reflects the latest cluster state. Pod age and memory usage calculations have been improved for accuracy. The filtering logic has been updated to use nodes as the primary source, mapping pods to nodes after node creation. This change ensures that pods are always associated with the correct, up-to-date node information.
Key Changes
Removed all mock node data from the workloads , dashboard .
Added periodic fetch (every 5 seconds) for nodes from the backend API.
Improved pod age and memory usage calculation logic.
Updated filter logic: nodes are created first, then pods are mapped to nodes.
Enhanced UI to reflect real-time node and pod state.
Cleaned up unused code and comments for clarity.
ScreenShots
Before: Even the node info is available , the filter is expecting from pods/containers data to map the nodes
After : Changed the logic to fetch from nodes data to map for filter component , removing dependency from pods , and removed mock data if no pods are available
step1 : when only node data is present
step2: when we run .helloworld.sh , which is dynamically updated , as the fetch logic is being called every 5 secs for new updates
🔗 Related Issue
closes->#294
🧪 Test Method
logs are printed in console on successful fetch
✅ Checklist
[✅] Code conventions are followed
[✅] Tests are added/modified
[✅] Documentation is updated (if necessary)