fix:Resolve warning in common, nodeagent to 0 warnings #337
Merged
youngtaekiim merged 8 commits intoeclipse-pullpiri:mainfrom Oct 14, 2025
Merged
fix:Resolve warning in common, nodeagent to 0 warnings #337youngtaekiim merged 8 commits intoeclipse-pullpiri:mainfrom
youngtaekiim merged 8 commits intoeclipse-pullpiri:mainfrom
Conversation
- Prefixed unused guest server function with underscore to prevent dead code warning - Cleaned up commented code and clarified comments - No functional changes, only warning suppression and code hygiene
Contributor
|
@leeeunkoo @youngtaekiim I finished my review for this PR. Please merge this. Thanks. |
- except for snake case all the build level warnings mitigated
Contributor
Author
|
@daeyoung-jeong-lge please check with these changes , The player submodule was reduced to 0 warnings in build , but as for clippy there are these 2 warnings i couldnt clear .
|
Contributor
|
@leeeunkoo @youngtaekiim I finished my review. Please merge this. Thanks. @LGSI-KarumuriHari Could you do the rest work about reducing the warnings of server (apiserver, monitoringserver, settingsservice, policymanager) with the separated PR? Thanks. |
youngtaekiim
approved these changes
Oct 14, 2025
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 PR Description
Resolve warning in common , nodeagent, tools .
🔗 Related Issue
#328
🧪 Test Method
cargo clippy in dedicated repos or make clippy in root folder
command used : cargo clippy 2>&1 | grep -c "warning:"
Screenshots:
node agent:
common
tools:
✅ Checklist
[✅] Code conventions are followed
[✅] Tests are added/modified
[✅] Documentation is updated (if necessary)