fix(sender): update StateManagerConnectionClient connection to use master IP from config (url : #330)#338
Merged
youngtaekiim merged 1 commit intoeclipse-pullpiri:mainfrom Oct 14, 2025
Conversation
…ster IP from config (url : eclipse-pullpiri#330)
Contributor
Author
|
@leeeunkoo @youngtaekiim |
youngtaekiim
approved these changes
Oct 14, 2025
Contributor
|
수정한 부분은 명확합니다. merge 하도록 하겠습니다. 그러나 이 commit에는 포함되지 않은 #[derive(Debug, Deserialize, Clone, Default, PartialEq)]
pub struct Config {
pub nodeagent: NodeAgentConfig,
}config struct 가 추후 확장될 여지가 있어서 두 번 포장을 하였지 아니면 nodeagent가 아닌 다른 module 에서도 config 쓰는 곳이 있어서 동일한 형식으로 했는지... |
Contributor
Author
아래 commit에서 추가된 사항인데 아마 은구 책임님께서 copilot agent를 이용해서 추가한 코드로 보입니다. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related to #330
There're "Failed to connect" errors when sending changed container list from NodeAgent to StateManager. Because NodeAgent lies on each Node, NodeAgent needs some other approach to connect to StateManager.