Skip to content

test(actioncontroller)- Unit test cases for actioncontroller with code coverage [#322]#395

Merged
youngtaekiim merged 3 commits intoeclipse-pullpiri:mainfrom
akshaylg0314:main
Dec 9, 2025
Merged

test(actioncontroller)- Unit test cases for actioncontroller with code coverage [#322]#395
youngtaekiim merged 3 commits intoeclipse-pullpiri:mainfrom
akshaylg0314:main

Conversation

@akshaylg0314
Copy link
Contributor

📝 PR Description

test(actioncontroller)- Unit test cases for actioncontroller with code coverage [#322]

🔗 Related Issue
Closes #322

🧪 Test Method
sudo cargo tarpaulin --skip-clean --exclude-files "/filtergateway/" --exclude-files "/statemanager/"
cargo test
cargo tarpaulin

Screenshot:

image

✅ Checklist
[✅] Code conventions are followed
[✅] Tests are added/modified
[✅] Documentation is updated (if necessary)

@akshaylg0314
Copy link
Contributor Author

Hey @daeyoung-jeong-lge @leeeunkoo @youngtaekiim
Please review the test code and merge
thanks!!

@youngtaekiim
Copy link
Contributor

Please check cargo deny error

error[unmaintained]: rustls-pemfile is unmaintained
    ┌─ /home/runner/work/pullpiri/pullpiri/src/tools/Cargo.lock:162:1
    │
162 │ rustls-pemfile 1.0.4 registry+https://github.com/rust-lang/crates.io-index
    │ ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ unmaintained advisory detected
    │
    ├ ID: RUSTSEC-2025-0134
    ├ Advisory: https://rustsec.org/advisories/RUSTSEC-2025-0134
    ├ The rustls-pemfile crate is no longer maintained. The repository has been archived since August
      2025, and users are encouraged to depend directly on the underlying PEM parsing code included
      in rustls-pki-types since 1.9.0. The latest version of rustls-pemfile is in fact a thin wrapper
      around the same code used in rustls-pki-types, so migrating should be straightforward.
      
      The new API is represented by the [`PemObject`][PemObject] trait, which provides methods for
      reading a single or multiple PEM objects from a file or byte slice.
      
      [PemObject]: https://docs.rs/rustls-pki-types/latest/rustls_pki_types/pem/trait.PemObject.html
    ├ Announcement: https://github.com/rustls/pemfile/issues/61
    ├ Solution: No safe upgrade is available!
    ├ rustls-pemfile v1.0.4
      └── reqwest v0.11.27
          └── settingscli v0.1.0

advisories FAILED, bans ok, licenses ok, sources ok
Error: Deny check for tools failed! Issues found.

@akshaylg0314
Copy link
Contributor Author

Please check cargo deny error

error[unmaintained]: rustls-pemfile is unmaintained
    ┌─ /home/runner/work/pullpiri/pullpiri/src/tools/Cargo.lock:162:1
    │
162 │ rustls-pemfile 1.0.4 registry+https://github.com/rust-lang/crates.io-index
    │ ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ unmaintained advisory detected
    │
    ├ ID: RUSTSEC-2025-0134
    ├ Advisory: https://rustsec.org/advisories/RUSTSEC-2025-0134
    ├ The rustls-pemfile crate is no longer maintained. The repository has been archived since August
      2025, and users are encouraged to depend directly on the underlying PEM parsing code included
      in rustls-pki-types since 1.9.0. The latest version of rustls-pemfile is in fact a thin wrapper
      around the same code used in rustls-pki-types, so migrating should be straightforward.
      
      The new API is represented by the [`PemObject`][PemObject] trait, which provides methods for
      reading a single or multiple PEM objects from a file or byte slice.
      
      [PemObject]: https://docs.rs/rustls-pki-types/latest/rustls_pki_types/pem/trait.PemObject.html
    ├ Announcement: https://github.com/rustls/pemfile/issues/61
    ├ Solution: No safe upgrade is available!
    ├ rustls-pemfile v1.0.4
      └── reqwest v0.11.27
          └── settingscli v0.1.0

advisories FAILED, bans ok, licenses ok, sources ok
Error: Deny check for tools failed! Issues found.

Yes i am checking this error

@akshaylg0314
Copy link
Contributor Author

Hey @youngtaekiim issue is fixed with #322
Thanks!!

@youngtaekiim
Copy link
Contributor

There is a problem about Eclipse ECA validation, so I cannot merge.

# Author(s) covered by necessary legal agreements
akshay14.garg@l*e DOT com

# Author(s) not covered by necessary legal agreements
Author Eclipse account cannot be found.
Email: gargakshay0314@gm*il DOT com
GitHub ID: akshayg0314
Committer Eclipse account cannot be found.
Email: gargakshay0314@gm*il DOT com
GitHub ID: akshayg0314

@akshayg0314
Copy link
Contributor

Hye @youngtaekiim i resolved the error please check and merge
thanks!!

@youngtaekiim youngtaekiim merged commit 13f5b44 into eclipse-pullpiri:main Dec 9, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[TASK] Add test codes for ActionController

3 participants