Rename QITE → DB_QITE to support multiple QITE methods#250
Rename QITE → DB_QITE to support multiple QITE methods#250Sam-XiaoyueLi wants to merge 4 commits intoeclipse-qrisp:mainfrom
Conversation
| def QITE(qarg, U_0, exp_H, s, k, method="GC"): | ||
| def QITE(qarg, procedure_type=None, *kwargs): | ||
| r""" | ||
| To anticipate other methods implementing QITE |
There was a problem hiding this comment.
| To anticipate other methods implementing QITE | |
| To anticipate other methods implementing QITE. |
|
Thats an interesting idea 🤔😊 I really like the possibility to directly exchange QITE strategies for comparison. However to make this modularity true, I think it would be good if we condensed the interface a bit better. Having just It could be helpful to review alternate QITE strategies to understand which arguments always appear ( |
This PR proposes to free up the name QITE if other imaginary-time evolution methods would at some point be added to Qrisp.
QITEimplementation toDB_QITE(Double-Bracket Quantum Imaginary-Time Evolution) to clarify that it’s one specific QITE variant.QITEmethod which handles the dispatch to potentially other approaches via theprocedure_type = argumentprocedure_type=db_qiteand so the PR is backwards compatible i.e. previousQITEcalls will execute DB-QITE as before.