Skip to content

Conversation

@hoe-jo
Copy link
Contributor

@hoe-jo hoe-jo commented Oct 30, 2025

No description provided.

@hoe-jo hoe-jo requested a review from a team as a code owner October 30, 2025 07:20
@eclipse-otterdog
Copy link
Contributor

Thank you for raising a pull request to update the configuration of your GitHub organization.
You can manually add reviewers to this PR to eventually enable auto-merging.

The following conditions need to fulfilled for auto-merging to be available:

  • valid configuration
  • approved by a project lead
  • does not require any secrets
  • does not update settings only accessible via the GitHub Web UI
  • does not remove any resource
Otterdog commands and options

You can trigger otterdog actions by commenting on this PR:

  • /otterdog team-info checks the team / org membership for the PR author
  • /otterdog validate validates the configuration change
  • /otterdog validate info validates the configuration change, printing also validation infos
  • /otterdog check-sync checks if the base ref is in sync with live settings
  • /otterdog merge merges and applies the changes if the PR is eligible for auto-merging (only accessible for the author)
  • /otterdog done notifies the self-service bot that a required manual apply operation has been performed (only accessible for members of the admin team)
  • /otterdog apply re-apply a previously failed attempt (only accessible for members of the admin team)

@eclipse-otterdog
Copy link
Contributor

The author (hoe-jo) of this PR is associated with this organization in the role of MEMBER.

Additionally, hoe-jo is a member of the following teams:

@eclipse-otterdog

This comment has been minimized.

@hoe-jo hoe-jo force-pushed the hoe_jo_add_limdor_codeowner_lola branch from a64099c to f5702f0 Compare October 30, 2025 07:27
@eclipse-otterdog

This comment has been minimized.

@hoe-jo hoe-jo force-pushed the hoe_jo_add_limdor_codeowner_lola branch from f5702f0 to 1b34a36 Compare October 30, 2025 08:19
@eclipse-otterdog

This comment has been minimized.

@kairoaraujo
Copy link
Contributor

The new members needs to be added to https://github.com/orgs/eclipse-score/teams

Copy link
Contributor

@FScholPer FScholPer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only committer can be codeowners.

@eclipse-otterdog

This comment has been minimized.

@eclipse-otterdog

This comment has been minimized.

@eclipse-otterdog

This comment has been minimized.

@eclipse-otterdog
Copy link
Contributor

Please find below the validation of the requested configuration changes:

Diff for c08e5a0
Project automotive.score[github_id=eclipse-score]
  there have been 26 validation infos, enable verbose output to display them.

  
!   team[name="codeowner-lola"] {
!     members = [
+      "bemerybmw"
+      "limdor"
!     ]
!   }

  
!   team[name="codeowner-baselibs"] {
!     members = [
+      "bemerybmw"
+      "limdor"
!     ]
!   }
  
  Plan: 0 to add, 2 to change, 0 to delete.

@eclipse-otterdog
Copy link
Contributor

Warning

The current configuration is out-of-sync with the live settings:

Diff to live settings
Project automotive.score[github_id=eclipse-score]
  there have been 26 validation infos, enable verbose output to display them.

  
!   repo_ruleset[name="main", repository=bazel_registry] {
!     bypass_actors = [
-      "#OrganizationAdmin"
!     ]
!   }
  
  Plan: 0 to add, 1 to change, 0 to delete.

Important

The current configuration needs to be updated to reflect the live settings otherwise they would be overwritten when this PR gets merged.

cc @eclipse-score/eclipsefdn-security

cc @eclipse-score/eclipsefdn-releng

mbarbero
mbarbero previously approved these changes Nov 21, 2025
@mbarbero mbarbero dismissed their stale review November 21, 2025 21:19

My bad, as far as I understand, @bemerybmw and @limdor should be removed from the 2 teams first.

@AlexanderLanin
Copy link
Member

side note: this does not configure codeowners. These teams can be used for bypass_actors. Not for codeowners.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants