-
Notifications
You must be signed in to change notification settings - Fork 3
bazel: Base changes to repository #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bazel: Base changes to repository #1
Conversation
`inc_orchestrator_internal` was used as a basis. - Update all dependencies. - Add additional config files (e.g., `.cargo/`, `rust-toolchain.toml`, `rustfmt.toml`). - Update `.github` to be more Rust-specific. - Update Bazel configuration (e.g., `BUILD`, `MODULE.bazel`). - Add `Cargo.toml` workspace definition. - Update licenses. - Update `docs/` and `README.md` (still WIP).
License Check Results🚀 The license check job ran with the Bazel command: bazel run //:license-checkStatus: Click to expand output |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR transforms a C++/Rust Bazel template repository into a dedicated Rust base libraries project. It updates all project metadata, dependencies, and configuration files to support a Rust-focused development environment with enhanced toolchain support including QNX8 and multiple platform targets.
Key changes:
- Updated project name from
cpp_rust_template_repositorytoscore_baselibs_rustwith version 0.0.1 - Added comprehensive Rust tooling configuration (rustfmt.toml, rust-toolchain.toml, .cargo/config.toml)
- Upgraded Bazel from 8.3.0 to 8.4.2 and significantly expanded MODULE.bazel with cross-platform toolchains
- Replaced Python-focused workflows with Rust-specific CI/CD (cargo build/test/coverage, clippy, miri)
Reviewed Changes
Copilot reviewed 29 out of 32 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| rustfmt.toml | New Rust formatting configuration with 150 char width and 4-space tabs |
| rust-toolchain.toml | Pins Rust toolchain to version 1.90.0 |
| pyproject.toml | Removed Python configuration as project shifts to Rust |
| docs/index.rst | Updated documentation title and copyright year for base libraries |
| docs/conf.py | Updated project metadata and added MyST parser for markdown support |
| README.md | Changed title from C++ & Rust template to Base Libraries - Rust |
| MODULE.bazel | Comprehensive rewrite adding QNX8, GCC, and Rust toolchains with git/archive overrides |
| LICENSE.md | Added Apache 2.0 license file with 2025 copyright |
| LICENSE | Added APPENDIX section with license application instructions |
| Cargo.toml | New workspace definition with lint rules and empty members arrays |
| BUILD | Added filtered Cargo.lock genrule and updated dash license checker |
| .vscode/settings.json | Added Rust-specific editor settings and adjusted Python rulers |
| .github/workflows/*.yml | Added/updated workflows for Rust testing, cargo checks, and updated copyright years |
| .github/actions/* | Added setup-rust-build action and updated gitlint copyright |
| .cargo/config.toml | Added rustflags to treat warnings as errors |
| .bazelversion | Updated Bazel version from 8.3.0 to 8.4.2 |
| .bazelrc | Added QNX credential helper and build_qnx8 platform configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Make examples and tests work, both with Cargo and Bazel. - Remove obsolete test examples. - Add Python dependency.
- Remove license headers check - should be done by Bazel checks. - Remove loom run.
|
The created documentation from the pull request is available at: docu-html |
pawelrutkaq
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The src/ l;evel scall contain seperate crates. So I would expect our folder there is log. Mw here is not needed imho. Also remove _placeholder in src
|
I looked into the build issue: It seems to be a problem of docs-as-code, :needs_json does not actually depend on :ide_support so it makes no sense to look for its runfiles. This is a symptom that the script believes it is running in interactive use case (bazel run) but it is a pure build (bazel build) here. Though I have still no idea why it fails here but not elsewhere. update 2025-11-17 16:30: I guess our best bet is to make docs-as-code handle both. eclipse-score/docs-as-code#304 |
|
@arkjedrz can you use doc as code 1.4.0 ? This shall work |
501963b to
aa9bfcd
Compare
- Reorganize repository. - Remove placeholders. - Remove unnecessary deps. - Improve docs. - Remove `.cargo/`. - Remove Cargo repo in `MODULE.bazel`.
aa9bfcd to
1ac692a
Compare
8c988dc to
755f901
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 34 out of 37 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Add git_override of the score_tooling dep. - Add copyright checks to examples and docs.
- Align Rust versions. - Remove self-dependency.
755f901 to
4b51f0c
Compare
pawelrutkaq
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Loks good as intial
vinodreddy-g
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for a starting structure.
orchestratorwas used as a basis..cargo/,rust-toolchain.toml,rustfmt.toml)..githubto be more Rust-specific.BUILD,MODULE.bazel).Cargo.tomlworkspace definition.docs/andREADME.md(still WIP).