Skip to content

Conversation

@arkjedrz
Copy link
Contributor

@arkjedrz arkjedrz commented Nov 16, 2025

orchestrator was used as a basis.

  • Update all dependencies.
  • Add additional config files (e.g., .cargo/, rust-toolchain.toml, rustfmt.toml).
  • Update .github to be more Rust-specific.
  • Update Bazel configuration (e.g., BUILD, MODULE.bazel).
  • Add Cargo.toml workspace definition.
  • Update licenses.
  • Update docs/ and README.md (still WIP).

`inc_orchestrator_internal` was used as a basis.
- Update all dependencies.
- Add additional config files (e.g., `.cargo/`, `rust-toolchain.toml`,
  `rustfmt.toml`).
- Update `.github` to be more Rust-specific.
- Update Bazel configuration (e.g., `BUILD`, `MODULE.bazel`).
- Add `Cargo.toml` workspace definition.
- Update licenses.
- Update `docs/` and `README.md` (still WIP).
@arkjedrz arkjedrz self-assigned this Nov 16, 2025
@github-actions
Copy link

github-actions bot commented Nov 16, 2025

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run //:license-check

Status: ⚠️ Needs Review

Click to expand output
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.4.2) and connecting to it...
INFO: Invocation ID: efa9d5e2-77cb-4daf-aa91-383fc340ab00
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
DEBUG: Rule 'rust_qnx8_toolchain+' indicated that a canonical reproducible form can be obtained by modifying arguments integrity = "sha256-eQOopREOYCL5vtTb6c1cwZrql4GVrJ1FqgxarQRe1xs="
DEBUG: Repository rust_qnx8_toolchain+ instantiated at:
  <builtin>: in <toplevel>
Repository rule http_archive defined at:
  /home/runner/.bazel/external/bazel_tools/tools/build_defs/repo/http.bzl:431:31: in <toplevel>
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
WARNING: For repository 'aspect_rules_lint', the root module requires module version [email protected], but got [email protected] in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'buildifier_prebuilt', the root module requires module version [email protected], but got [email protected] in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
Computing main repo mapping: 
Loading: 
Loading: 0 packages loaded
Loading: 0 packages loaded
Loading: 0 packages loaded
    currently loading: 
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)

Analyzing: target //:license-check (25 packages loaded, 9 targets configured)

Analyzing: target //:license-check (125 packages loaded, 520 targets configured)

Analyzing: target //:license-check (135 packages loaded, 2039 targets configured)

Analyzing: target //:license-check (138 packages loaded, 2544 targets configured)

Analyzing: target //:license-check (138 packages loaded, 2544 targets configured)

Analyzing: target //:license-check (150 packages loaded, 4732 targets configured)

INFO: Analyzed target //:license-check (151 packages loaded, 4858 targets configured).
INFO: From Generating Dash formatted dependency file ...:
WARNING: No packages found in Cargo.lock.
INFO: Successfully converted 0 packages from Cargo.lock to bazel-out/k8-fastbuild/bin/formatted.txt
INFO: Found 1 target...
Target //:license.check.license_check up-to-date:
  bazel-bin/license.check.license_check
  bazel-bin/license.check.license_check.jar
INFO: Elapsed time: 23.809s, Critical Path: 0.35s
INFO: 14 processes: 5 disk cache hit, 9 internal.
INFO: Build completed successfully, 14 total actions
INFO: Running command line: bazel-bin/license.check.license_check ./formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR transforms a C++/Rust Bazel template repository into a dedicated Rust base libraries project. It updates all project metadata, dependencies, and configuration files to support a Rust-focused development environment with enhanced toolchain support including QNX8 and multiple platform targets.

Key changes:

  • Updated project name from cpp_rust_template_repository to score_baselibs_rust with version 0.0.1
  • Added comprehensive Rust tooling configuration (rustfmt.toml, rust-toolchain.toml, .cargo/config.toml)
  • Upgraded Bazel from 8.3.0 to 8.4.2 and significantly expanded MODULE.bazel with cross-platform toolchains
  • Replaced Python-focused workflows with Rust-specific CI/CD (cargo build/test/coverage, clippy, miri)

Reviewed Changes

Copilot reviewed 29 out of 32 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
rustfmt.toml New Rust formatting configuration with 150 char width and 4-space tabs
rust-toolchain.toml Pins Rust toolchain to version 1.90.0
pyproject.toml Removed Python configuration as project shifts to Rust
docs/index.rst Updated documentation title and copyright year for base libraries
docs/conf.py Updated project metadata and added MyST parser for markdown support
README.md Changed title from C++ & Rust template to Base Libraries - Rust
MODULE.bazel Comprehensive rewrite adding QNX8, GCC, and Rust toolchains with git/archive overrides
LICENSE.md Added Apache 2.0 license file with 2025 copyright
LICENSE Added APPENDIX section with license application instructions
Cargo.toml New workspace definition with lint rules and empty members arrays
BUILD Added filtered Cargo.lock genrule and updated dash license checker
.vscode/settings.json Added Rust-specific editor settings and adjusted Python rulers
.github/workflows/*.yml Added/updated workflows for Rust testing, cargo checks, and updated copyright years
.github/actions/* Added setup-rust-build action and updated gitlint copyright
.cargo/config.toml Added rustflags to treat warnings as errors
.bazelversion Updated Bazel version from 8.3.0 to 8.4.2
.bazelrc Added QNX credential helper and build_qnx8 platform configuration

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

- Make examples and tests work, both with Cargo and Bazel.
- Remove obsolete test examples.
- Add Python dependency.
- Remove license headers check - should be done by Bazel checks.
- Remove loom run.
@github-actions
Copy link

The created documentation from the pull request is available at: docu-html

Copy link
Contributor

@pawelrutkaq pawelrutkaq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The src/ l;evel scall contain seperate crates. So I would expect our folder there is log. Mw here is not needed imho. Also remove _placeholder in src

@a-zw
Copy link

a-zw commented Nov 17, 2025

I looked into the build issue:

Could not find runfiles_dir at /home/runner/.bazel/execroot/_main/bazel-bin/ide_support.runfiles. Have a look at README.md for instructions on how to build docs.

It seems to be a problem of docs-as-code, :needs_json does not actually depend on :ide_support so it makes no sense to look for its runfiles. This is a symptom that the script believes it is running in interactive use case (bazel run) but it is a pure build (bazel build) here. Though I have still no idea why it fails here but not elsewhere.

update 2025-11-17 16:30:
This log messages comes from docs-as-code src/extensions/score_plantuml.py which is an extension loaded by Sphinx. For some reason Bazel decided to use RUNFILES_MANIFEST_FILE instead of RUNFILES_DIR. Afaik rules can be "manifest-only" which forces Bazel to rely on a manifest.

I guess our best bet is to make docs-as-code handle both. eclipse-score/docs-as-code#304

@pawelrutkaq
Copy link
Contributor

@arkjedrz can you use doc as code 1.4.0 ? This shall work

@arkjedrz arkjedrz force-pushed the arkjedrz_base-changes branch from 501963b to aa9bfcd Compare November 17, 2025 13:55
- Reorganize repository.
- Remove placeholders.
- Remove unnecessary deps.
- Improve docs.
- Remove `.cargo/`.
- Remove Cargo repo in `MODULE.bazel`.
@arkjedrz arkjedrz force-pushed the arkjedrz_base-changes branch from aa9bfcd to 1ac692a Compare November 17, 2025 15:09
@arkjedrz arkjedrz marked this pull request as ready for review November 17, 2025 15:16
@arkjedrz arkjedrz requested a review from pawelrutkaq November 17, 2025 15:16
@arkjedrz arkjedrz force-pushed the arkjedrz_base-changes branch from 8c988dc to 755f901 Compare November 18, 2025 07:46
@arkjedrz arkjedrz requested review from Copilot and nicu1989 November 18, 2025 07:46
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 34 out of 37 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

- Add git_override of the score_tooling dep.
- Add copyright checks to examples and docs.
- Align Rust versions.
- Remove self-dependency.
@arkjedrz arkjedrz force-pushed the arkjedrz_base-changes branch from 755f901 to 4b51f0c Compare November 18, 2025 08:08
Copy link
Contributor

@pawelrutkaq pawelrutkaq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loks good as intial

Copy link
Contributor

@vinodreddy-g vinodreddy-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for a starting structure.

@vinodreddy-g vinodreddy-g merged commit e290d66 into eclipse-score:main Nov 18, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants