Skip to content

Conversation

@arkjedrz
Copy link
Contributor

@arkjedrz arkjedrz commented Dec 1, 2025

  • Replacement for core::fmt.
  • Partial implementation of common types.
  • ScoreDebug implementation helpers.
  • Unit tests.

Notes for Reviewer

Pre-Review Checklist for the PR Author

  • PR title is short, expressive and meaningful
  • Commits are properly organized
  • Relevant issues are linked in the References section
  • Tests are conducted
  • Unit tests are added

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Unit tests have been written for new behavior
  • Public API is documented
  • PR title describes the changes

Post-review Checklist for the PR Author

  • All open points are addressed and tracked via issues

References

Closes #

@github-actions
Copy link

github-actions bot commented Dec 1, 2025

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run //:license-check

Status: ⚠️ Needs Review

Click to expand output
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.4.2) and connecting to it...
INFO: Invocation ID: 0d82c3d8-f290-4798-9876-a4a57823bb84
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
DEBUG: Rule 'rust_qnx8_toolchain+' indicated that a canonical reproducible form can be obtained by modifying arguments integrity = "sha256-eQOopREOYCL5vtTb6c1cwZrql4GVrJ1FqgxarQRe1xs="
DEBUG: Repository rust_qnx8_toolchain+ instantiated at:
  <builtin>: in <toplevel>
Repository rule http_archive defined at:
  /home/runner/.bazel/external/bazel_tools/tools/build_defs/repo/http.bzl:431:31: in <toplevel>
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
WARNING: For repository 'aspect_rules_lint', the root module requires module version [email protected], but got [email protected] in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'buildifier_prebuilt', the root module requires module version [email protected], but got [email protected] in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
Loading: 
Loading: 0 packages loaded
Loading: 0 packages loaded
Loading: 0 packages loaded
    currently loading: 
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)

Analyzing: target //:license-check (27 packages loaded, 9 targets configured)

Analyzing: target //:license-check (80 packages loaded, 9 targets configured)

Analyzing: target //:license-check (85 packages loaded, 20 targets configured)

Analyzing: target //:license-check (135 packages loaded, 1836 targets configured)

Analyzing: target //:license-check (142 packages loaded, 2567 targets configured)

Analyzing: target //:license-check (142 packages loaded, 2567 targets configured)

Analyzing: target //:license-check (147 packages loaded, 4818 targets configured)

INFO: Analyzed target //:license-check (152 packages loaded, 4876 targets configured).
INFO: From Generating Dash formatted dependency file ...:
WARNING: No packages found in Cargo.lock.
INFO: Successfully converted 0 packages from Cargo.lock to bazel-out/k8-fastbuild/bin/formatted.txt
INFO: Found 1 target...
Target //:license.check.license_check up-to-date:
  bazel-bin/license.check.license_check
  bazel-bin/license.check.license_check.jar
INFO: Elapsed time: 33.461s, Critical Path: 0.38s
INFO: 14 processes: 5 disk cache hit, 9 internal.
INFO: Build completed successfully, 14 total actions
INFO: Running command line: bazel-bin/license.check.license_check ./formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

@github-actions
Copy link

github-actions bot commented Dec 1, 2025

The created documentation from the pull request is available at: docu-html

@arkjedrz arkjedrz force-pushed the arkjedrz_mw-log-fmt branch 3 times, most recently from b0d0746 to 1c72c62 Compare December 5, 2025 11:31
@arkjedrz arkjedrz marked this pull request as ready for review December 5, 2025 11:42
@arkjedrz arkjedrz force-pushed the arkjedrz_mw-log-fmt branch 2 times, most recently from eaef04f to fedc045 Compare December 5, 2025 12:26
@arkjedrz arkjedrz force-pushed the arkjedrz_mw-log-fmt branch 5 times, most recently from 330bfe7 to ef0ca2f Compare December 8, 2025 12:02
Copy link
Contributor

@pawelrutkaq pawelrutkaq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link also appropriate issue from #15

Copy link
Contributor

@awillenbuecher-xq-tec awillenbuecher-xq-tec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay from my side, once Pawel's comments have been addressed.

@arkjedrz arkjedrz requested a review from Copilot December 9, 2025 10:54
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces the mw_log_fmt implementation as a replacement for core::fmt, providing a custom formatting library for non-text-based message frames. It includes partial implementations of common types, ScoreDebug trait and helper builders, along with comprehensive unit tests.

Key changes:

  • Implementation of custom formatting infrastructure (ScoreWrite, ScoreDebug, builders)
  • Support for primitive types and common Rust types (slices, arrays, Vec, Rc, Arc)
  • Helper builders for structured debug output (DebugStruct, DebugTuple, DebugList, DebugSet, DebugMap)

Reviewed changes

Copilot reviewed 18 out of 19 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/log/src/lib.rs Removed placeholder library code
src/log/Cargo.toml Removed placeholder Cargo manifest
src/log/BUILD Removed placeholder build configuration
src/log/mw_log_fmt/lib.rs Main library module defining the public API and module structure
src/log/mw_log_fmt/Cargo.toml Cargo manifest for the new formatting library
src/log/mw_log_fmt/BUILD Bazel build configuration for the library and tests
src/log/mw_log_fmt/fmt.rs Core formatting traits and types (ScoreWrite, ScoreDebug, Error, Arguments)
src/log/mw_log_fmt/fmt_spec.rs Format specification types and enums for controlling output formatting
src/log/mw_log_fmt/fmt_impl.rs ScoreDebug implementations for primitive and common Rust types
src/log/mw_log_fmt/fmt_impl_qm.rs Feature-gated ScoreDebug implementations for non-ASIL-B certified types
src/log/mw_log_fmt/builders.rs Helper builders for structured debug output formatting
src/log/mw_log_fmt/macros.rs Formatting macros (score_write!, score_writeln!)
src/log/mw_log_fmt/test_utils.rs Testing utilities including StringWriter and common_test_debug
Cargo.toml Updated workspace members to include new library
.vscode/settings.json Added "qm" feature to rust-analyzer configuration
docs/module/log/detailed_design/_assets/log_op.puml Updated diagram to remove ScoreDisplay references
docs/module/log/detailed_design/_assets/class_diagram.puml Updated class diagram to reflect API changes
docs/module/log/architecture/_assets/interface.puml Updated architecture diagram to remove ScoreDisplay

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

- Replacement for `core::fmt`.
- Partial implementation of common types.
- `ScoreDebug` implementation helpers.
- Unit tests.
@arkjedrz arkjedrz force-pushed the arkjedrz_mw-log-fmt branch from 4e00a73 to e25ec9f Compare December 9, 2025 10:56
@arkjedrz arkjedrz requested a review from Copilot December 9, 2025 10:56
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 18 out of 19 changed files in this pull request and generated 4 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@arkjedrz arkjedrz requested a review from arsibo December 10, 2025 07:39
@arsibo arsibo merged commit 6debd46 into eclipse-score:main Dec 11, 2025
11 checks passed
@arkjedrz arkjedrz deleted the arkjedrz_mw-log-fmt branch December 11, 2025 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants