-
Notifications
You must be signed in to change notification settings - Fork 3
ABI-compatible and fixed-capacity queues #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
License Check Results🚀 The license check job ran with the Bazel command: bazel run //:license-checkStatus: Click to expand output |
|
The created documentation from the pull request is available at: docu-html |
pawelrutkaq
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minors
src/containers/generic/queue.rs
Outdated
| pub struct GenericQueue<T, S: Storage<T>> { | ||
| /// The current number of elements in the queue. | ||
| len: u32, | ||
| /// The index of the first element. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FIFO elem or LIFO elem or ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clarified comment
| } | ||
| } | ||
|
|
||
| impl core::error::Error for QueueFull {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe a note that UT are implemented for specific usage of Generic S. However I think they shall be here, as they shall not depend on S
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. I added unit tests for both generic containers using std Vec for storage.
a018083 to
7f7d8ff
Compare
This PR adds two data structures to the Rust base libs: an inline-storage (ABI-compatible) and a fixed-capacity queue. Refer to the feature request for more information about ABI compatibility.
Notes for Reviewer
Pre-Review Checklist for the PR Author
Checklist for the PR Reviewer
Post-review Checklist for the PR Author
References