-
Notifications
You must be signed in to change notification settings - Fork 4
log: add Rust log init for C++ #53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
log: add Rust log init for C++ #53
Conversation
License Check Results🚀 The license check job ran with the Bazel command: bazel run //:license-checkStatus: Click to expand output |
|
The created documentation from the pull request is available at: docu-html |
17634ab to
b83ad26
Compare
b83ad26 to
1303555
Compare
src/log/stdout_logger_init/BUILD
Outdated
| ) | ||
|
|
||
| cc_library( | ||
| name = "stdout_logger_init", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
stdout_logger_cpp ? and same for folder ? or some other name, init is valid in any lang
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
stdout_logger_cpp_init? Indicates language and purpose.
Should stdout_logger_init.hpp also be renamed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
stdout_logger_init.hpp maybe not becasue it's already in given language by suffix. Btw I think we use .h and not .hpp ?
|
|
||
| /// Show example logs using function-logger logger instance. | ||
| #[no_mangle] | ||
| extern "C" fn show_logs_local_logger() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would remove those, this will work (and is nothing cpp side controls) and make the example more blur.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove what?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whole show_logs_local_logger
1303555 to
fc88f61
Compare
fc88f61 to
73e64d0
Compare
73e64d0 to
f33f2c5
Compare
- Add lib for log init when Rust lib is used by C++. - Add example.
f33f2c5 to
40cbc0d
Compare
Notes for Reviewer
Pre-Review Checklist for the PR Author
Checklist for the PR Reviewer
Post-review Checklist for the PR Author
References
Closes #