Skip to content

Conversation

@arkjedrz
Copy link
Contributor

@arkjedrz arkjedrz commented Jan 23, 2026

  • Add lib for log init when Rust lib is used by C++.
  • Add example.

Notes for Reviewer

Pre-Review Checklist for the PR Author

  • PR title is short, expressive and meaningful
  • Commits are properly organized
  • Relevant issues are linked in the References section
  • Tests are conducted
  • Unit tests are added

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Unit tests have been written for new behavior
  • Public API is documented
  • PR title describes the changes

Post-review Checklist for the PR Author

  • All open points are addressed and tracked via issues

References

Closes #

@arkjedrz arkjedrz self-assigned this Jan 23, 2026
@arkjedrz arkjedrz requested a review from pawelrutkaq January 23, 2026 14:49
@github-actions
Copy link

github-actions bot commented Jan 23, 2026

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run //:license-check

Status: ⚠️ Needs Review

Click to expand output
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.4.2) and connecting to it...
INFO: Invocation ID: 18884078-d0f2-48c9-9191-312c5a7eed6d
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
DEBUG: Rule 'rust_qnx8_toolchain+' indicated that a canonical reproducible form can be obtained by modifying arguments integrity = "sha256-eQOopREOYCL5vtTb6c1cwZrql4GVrJ1FqgxarQRe1xs="
DEBUG: Repository rust_qnx8_toolchain+ instantiated at:
  <builtin>: in <toplevel>
Repository rule http_archive defined at:
  /home/runner/.bazel/external/bazel_tools/tools/build_defs/repo/http.bzl:431:31: in <toplevel>
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
WARNING: For repository 'bazel_skylib', the root module requires module version [email protected], but got [email protected] in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'rules_cc', the root module requires module version [email protected], but got [email protected] in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'aspect_rules_lint', the root module requires module version [email protected], but got [email protected] in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'buildifier_prebuilt', the root module requires module version [email protected], but got [email protected] in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'score_docs_as_code', the root module requires module version [email protected], but got [email protected] in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
Loading: 
Loading: 0 packages loaded
Loading: 0 packages loaded
Loading: 0 packages loaded
    currently loading: 
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)

Analyzing: target //:license-check (31 packages loaded, 10 targets configured)

Analyzing: target //:license-check (85 packages loaded, 10 targets configured)

Analyzing: target //:license-check (141 packages loaded, 1489 targets configured)

Analyzing: target //:license-check (144 packages loaded, 2248 targets configured)

Analyzing: target //:license-check (145 packages loaded, 2719 targets configured)

Analyzing: target //:license-check (145 packages loaded, 2719 targets configured)

INFO: Analyzed target //:license-check (156 packages loaded, 9013 targets configured).
[1 / 1] no actions running
INFO: From Generating Dash formatted dependency file ...:
INFO: Successfully converted 4 packages from Cargo.lock to bazel-out/k8-fastbuild/bin/formatted.txt
INFO: Found 1 target...
Target //:license.check.license_check up-to-date:
  bazel-bin/license.check.license_check
  bazel-bin/license.check.license_check.jar
INFO: Elapsed time: 25.271s, Critical Path: 0.43s
INFO: 14 processes: 5 disk cache hit, 9 internal.
INFO: Build completed successfully, 14 total actions
INFO: Running command line: bazel-bin/license.check.license_check ./formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

@github-actions
Copy link

The created documentation from the pull request is available at: docu-html

@arkjedrz arkjedrz force-pushed the arkjedrz_stdout-logger-init branch from 17634ab to b83ad26 Compare January 26, 2026 13:45
@arkjedrz arkjedrz force-pushed the arkjedrz_stdout-logger-init branch from b83ad26 to 1303555 Compare January 26, 2026 13:46
)

cc_library(
name = "stdout_logger_init",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stdout_logger_cpp ? and same for folder ? or some other name, init is valid in any lang

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stdout_logger_cpp_init? Indicates language and purpose.
Should stdout_logger_init.hpp also be renamed?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stdout_logger_init.hpp maybe not becasue it's already in given language by suffix. Btw I think we use .h and not .hpp ?


/// Show example logs using function-logger logger instance.
#[no_mangle]
extern "C" fn show_logs_local_logger() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would remove those, this will work (and is nothing cpp side controls) and make the example more blur.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove what?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whole show_logs_local_logger

@arkjedrz arkjedrz force-pushed the arkjedrz_stdout-logger-init branch from 1303555 to fc88f61 Compare January 26, 2026 14:12
@arkjedrz arkjedrz force-pushed the arkjedrz_stdout-logger-init branch from fc88f61 to 73e64d0 Compare January 26, 2026 14:19
@arkjedrz arkjedrz force-pushed the arkjedrz_stdout-logger-init branch from 73e64d0 to f33f2c5 Compare January 26, 2026 14:40
@arkjedrz arkjedrz temporarily deployed to workflow-approval January 26, 2026 14:40 — with GitHub Actions Inactive
@arkjedrz arkjedrz marked this pull request as ready for review January 27, 2026 07:13
@arkjedrz arkjedrz requested a review from pawelrutkaq January 27, 2026 07:47
pawelrutkaq
pawelrutkaq previously approved these changes Jan 27, 2026
- Add lib for log init when Rust lib is used by C++.
- Add example.
@pawelrutkaq pawelrutkaq merged commit 185ae10 into eclipse-score:main Jan 27, 2026
12 checks passed
@arkjedrz arkjedrz deleted the arkjedrz_stdout-logger-init branch January 28, 2026 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants