Pass DOCKER_HOST environment variable#212
Merged
LittleHuba merged 2 commits intoeclipse-score:mainfrom Mar 23, 2026
Merged
Conversation
LittleHuba
reviewed
Mar 20, 2026
.bazelrc
Outdated
| test --sandbox_tmpfs_path=/tmp | ||
|
|
||
| # Pass through DOCKER_HOST to support custom Docker setups, in particular rootless Docker | ||
| test --test_env=DOCKER_HOST |
Contributor
There was a problem hiding this comment.
This is only required for integration tests IMHO.
I would prefer a way to only set this for integration tests that run with the docker environment. The more variables we leak into our sandbox the less hermetic we are.
See https://bazel.build/reference/be/common-definitions#test.env_inherit and add that to
Contributor
Author
There was a problem hiding this comment.
Good point. Did update. Now local to integration tests. Please check new approach :)
Now env_inherit attributes passed ot py_test are now also respected in run_as_exec macro
Adds a pass-through for the DOCKER_HOST environment variable for docker-based (integration) tests. This enables e.g. rootless Docker setups.
hoppe-and-dreams
force-pushed
the
dockerhost
branch
from
ab9278e to
fce5319
Compare
hoppe-and-dreams
requested review from
bemerybmw,
castler,
crimson11,
hoe-jo and
limdor
as code owners
LittleHuba
approved these changes
Mar 23, 2026
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a pass-through for the DOCKER_HOST environment variable, allowing users to specify a custom Docker host.
This enables rootless Docker setups.