mw/com: migrate_umlet_to_plantuml__runtime#47
mw/com: migrate_umlet_to_plantuml__runtime#47kalu-an wants to merge 4 commits intoeclipse-score:mainfrom
Conversation
There was a problem hiding this comment.
The return type should use the correct namespace separator. Please update impl::lola:IMessagePassingService& to impl::lola::IMessagePassingService&
There was a problem hiding this comment.
Dear @sahithi-nukala thank you for your review and providing suggestions. Due to amount of diagrams and size of them I would like you to provide your changes like this
#50 (review)
thanks in advance
There was a problem hiding this comment.
In PlantUML:
-runtime_bindings_ : std:unordered_map<BindingType, std::unique_ptr>
In Umlet:
-runtime_bindings_ : std::unordered_map<BindingType, std::unique_ptr>
Issue: The PlantUML version is missing a colon in the namespace — it incorrectly uses std:unordered_map instead of std::unordered_map.
Solution: Update the PlantUML line to:
-runtime_bindings_ : std::unordered_map<BindingType, std::unique_ptr>
There was a problem hiding this comment.
Dear @sahithi-nukala thank you for your review and providing suggestions. Due to amount of diagrams and size of them I would like you to provide your changes like this
#50 (review)
thanks in advance
Co-authored-by: sahithi-nukala <91167569+sahithi-nukala@users.noreply.github.com> Signed-off-by: Andreas Kaluza <andreas.kaluza@continental.com>
Co-authored-by: sahithi-nukala <91167569+sahithi-nukala@users.noreply.github.com> Signed-off-by: Andreas Kaluza <andreas.kaluza@continental.com>
|
Under Integration |
Closes eclipse-score#47 Issue: SWP-208704 GIT_ORIGIN_SPP_REV_ID: 9589a1ec09795702b678ca4d078571865579e2c7
4 participants
Closes original PR #20 by creating smaller size pull requests on per directory within
/score/mw/com/designdirectoryCovered parts: