Conversation
License Check Results🚀 The license check job ran with the Bazel command: bazel run //:license-checkStatus: Click to expand output |
|
The created documentation from the pull request is available at: docu-html |
a2d5827 to
252043c
Compare
lurtz
left a comment
There was a problem hiding this comment.
I am not feeling well with pushing this through.
First everything is in Rust. As we have no safety qualified Rust toolchain, I prefer code which has to meet ASIL-B requirements to be in C++. I know that is absurd, but in the worst case we have to rewrite the Rust in C++. At S-CORE architects Rust is also a topic with a heated discussion: https://github.com/orgs/eclipse-score/discussions/1922#discussioncomment-14891648
S-CORE decided to write new code in Rust, but they do not know if that can be safety qualified until the release.
Next is the use of Iceoryx2. I thought we only use one IPC mechanism in S-CORE.
|
@lurtz the final decision on using Rust for safety-critical components is planned for February, which is roughly 2 months from now (accounting for christmas vacation and new years eve). From my point of view, the period until then can still be treated as PoC and architectural exploration rather than series delivery. Based on that, I propose to continue the gateway PoC in Rust for now. Reasoning:
This treats Rust as a tool for architectural stress testing, not as a language commitment. If there are concrete downsides to this approach, let us list them so we can evaluate them openly. |
'Iceoryx2' is used behind |
LittleHuba
left a comment
There was a problem hiding this comment.
Hey all,
this PR is currently not aligned in the communication CFT. This must be reevaluated, with the new information that Rust is not mandatory for new implementations anymore.
Please don't get me wrong, I find Rust cool and want to have it in S-CORE. And to do that we have to do one step after the other. One crucial first step is to achieve qualification readiness for Rust. And in the last meeting it was agreed that the timeline is at least difficult to meet.
With this understanding, introducing more and more Rust code into the project at this stage comes with a risk. The risk that we have to exclude all these parts from the release. I hope that I'm correct in evaluating releasability higher than introducing more Rust code in our project.
We agreed in the last Communication FT weekly that we postpone the ASIL-B part of the gateway as far as we can, in the hope of having a better understanding of the qualification timeline of Rust.
So please everybody, adhere to what we agreed in the weekly. I understand, that the discussion was cut short yesterday, because we ran out of time. Let's discuss this in the breakout session for the gateway further.
@pawelrutkaq I strongly disagree. Consensus in S-CORE is that there is no code duplication. Introducing a second IPC framework is violating this decision. Further, including iceoryx here completely ignores the concerns the project raised in terms of code qualification. As we agreed, for a MVP it was okay that you did this shortcut. But for inclusion in the S-CORE project we require the switch to mw::com with LoLa underneath. Please let's finish the discussion for our approach to the gateway before we go ahead. |
|
As #2 has been merged, can we close this PR? |
No description provided.