Skip to content

git: Update gitlint to be generic #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

git: Update gitlint to be generic #9

wants to merge 1 commit into from

Conversation

nicu1989
Copy link
Member

@nicu1989 nicu1989 commented Apr 3, 2025 •
edited by AlexanderLanin
Loading

Use correct link to docs in gitlint error message.
Use base-branch input instead of hardcoded main.
Add .gitlint.

@nicu1989
git: Update gitlint to be generic
021c689 
Use correct link to docs in gitlint error message.
Use base-branch input instead of hardcoded main.

Signed-off-by: Nicolae Dicu <[email protected]>
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 3, 2025

License Check Results

🚀 The license check preparation job ran successfully.

Status: ⚠️ Needs Review

Click to expand output 
2025/04/03 09:14:50 Downloading https://releases.bazel.build/7.4.0/release/bazel-7.4.0-linux-x86_64...
Extracting Bazel installation...
Starting local Bazel server and connecting to it...
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
WARNING: For repository 'googletest', the root module requires module version [email protected], but got [email protected] in the resolved dependency graph.
Computing main repo mapping: 
Loading: 
Loading: 0 packages loaded
WARNING: Target pattern parsing failed.
ERROR: Skipping '//docs:license.check.python': no such target '//docs:license.check.python': target 'license.check.python' not declared in package 'docs' defined by /home/runner/work/module_template/module_template/docs/BUILD
ERROR: no such target '//docs:license.check.python': target 'license.check.python' not declared in package 'docs' defined by /home/runner/work/module_template/module_template/docs/BUILD
INFO: Elapsed time: 8.291s
INFO: 0 processes.
ERROR: Build did NOT complete successfully
ERROR: Build failed. Not running target

@AlexanderLanin AlexanderLanin requested a review from Copilot April 4, 2025 15:06
Copilot
Copilot AI reviewed Apr 4, 2025
View reviewed changes
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • .gitlint: Language not supported

@AlexanderLanin
Copy link
Member

In this case we should really discuss it. Since we don't follow gitlint anyway, it may not make any sense to merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
Infrastructure
Status: Draft
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicu1989 @AlexanderLanin