impl: remove log support

Replace `log` crate with `mw_log` and provided Rust backend.

Author: arkjedrz

.github/workflows/check.yml

@@ -38,7 +38,7 @@ jobs:
 
       - name: Cargo Clippy
         run: |
-          cargo clippy --all-targets --features logging -- -D warnings
+          cargo clippy --all-targets --features stdout_logger -- -D warnings
 
       - name: Cargo Fmt
         run: |

Cargo.lock

@@ -15,6 +15,9 @@ edition = "2021"
 [workspace.dependencies]
 rust_kvs = { path = "src/rust/rust_kvs" }
 rust_kvs_tool = { path = "src/rust/rust_kvs_tool" }
+mw_log = { git = "https://github.com/eclipse-score/baselibs_rust.git", rev = "7b8ddb142ec4affe9c6a319b60f04302e96004f2", features = [
+    "qm",
+] }
 
 adler32 = "1.2.0"
 tinyjson = "2.5.1"

Cargo.toml

@@ -15,7 +15,6 @@ load("@rules_rust//rust:defs.bzl", "rust_library", "rust_test")
 rust_library(
     name = "rust_kvs",
     srcs = glob(["src/**/*.rs"]),
-    crate_features = ["score-log"],
     visibility = ["//visibility:public"],
     deps = [
         "@score_baselibs_rust//src/log/mw_log",
@@ -27,7 +26,6 @@ rust_library(
 rust_test(
     name = "tests",
     crate = "rust_kvs",
-    crate_features = ["score-log"],
     tags = [
         "unit_tests",
         "ut",

src/rust/rust_kvs/BUILD

@@ -7,13 +7,7 @@ edition.workspace = true
 [dependencies]
 adler32.workspace = true
 tinyjson.workspace = true
-log = { version = "0.4.29", optional = true }
-
-
-[features]
-default = ["logging"]
-score-log = []
-logging = ["log"]
+mw_log.workspace = true
 
 
 [dev-dependencies]

src/rust/rust_kvs/Cargo.toml

@@ -11,13 +11,12 @@
 
 extern crate alloc;
 
-use crate::log::error;
 use alloc::string::FromUtf8Error;
 use core::array::TryFromSliceError;
+use mw_log::error;
 
 /// Runtime Error Codes
-#[derive(Debug, PartialEq)]
-#[cfg_attr(feature = "score-log", derive(mw_log::ScoreDebug))]
+#[derive(Debug, PartialEq, mw_log::ScoreDebug)]
 pub enum ErrorCode {
     /// Error that was not yet mapped
     UnmappedError,

src/rust/rust_kvs/src/error_code.rs

@@ -13,7 +13,7 @@ use crate::error_code::ErrorCode;
 use crate::kvs_api::{InstanceId, SnapshotId};
 use crate::kvs_backend::KvsBackend;
 use crate::kvs_value::{KvsMap, KvsValue};
-use crate::log::{debug, error, trace};
+use mw_log::{debug, error, trace};
 use std::collections::HashMap;
 use std::fs;
 use std::path::{Path, PathBuf};
@@ -200,8 +200,7 @@ impl Default for JsonBackendBuilder {
 }
 
 /// KVS backend implementation based on TinyJSON.
-#[derive(Clone, Debug, PartialEq)]
-#[cfg_attr(feature = "score-log", derive(mw_log::ScoreDebug))]
+#[derive(Clone, Debug, PartialEq, mw_log::ScoreDebug)]
 pub struct JsonBackend {
     working_dir: PathBuf,
     snapshot_max_count: usize,

src/rust/rust_kvs/src/json_backend.rs

@@ -10,16 +10,15 @@
 // SPDX-License-Identifier: Apache-2.0
 
 use crate::error_code::ErrorCode;
-use crate::kvs_api::{DebugT, InstanceId, KvsApi, KvsDefaults, KvsLoad, SnapshotId};
+use crate::kvs_api::{InstanceId, KvsApi, KvsDefaults, KvsLoad, SnapshotId};
 use crate::kvs_backend::KvsBackend;
 use crate::kvs_builder::KvsData;
 use crate::kvs_value::{KvsMap, KvsValue};
-use crate::log::{error, warn};
+use mw_log::{error, fmt::ScoreDebug, warn};
 use std::sync::{Arc, Mutex};
 
 /// KVS instance parameters.
-#[derive(Debug)]
-#[cfg_attr(feature = "score-log", derive(mw_log::ScoreDebug))]
+#[derive(mw_log::ScoreDebug)]
 pub struct KvsParameters {
     /// Instance ID.
     pub instance_id: InstanceId,
@@ -153,7 +152,7 @@ impl KvsApi for Kvs {
     fn get_value_as<T>(&self, key: &str) -> Result<T, ErrorCode>
     where
         for<'a> T: TryFrom<&'a KvsValue>,
-        for<'a> <T as TryFrom<&'a KvsValue>>::Error: DebugT,
+        for<'a> <T as TryFrom<&'a KvsValue>>::Error: ScoreDebug,
     {
         let data = self.data.lock()?;
         if let Some(value) = data.kvs_map.get(key) {
@@ -349,8 +348,7 @@ mod kvs_tests {
 
     /// Most tests can be performed with mocked backend.
     /// Only those with file handling must use concrete implementation.
-    #[derive(PartialEq, Debug)]
-    #[cfg_attr(feature = "score-log", derive(mw_log::ScoreDebug))]
+    #[derive(PartialEq, Debug, mw_log::ScoreDebug)]
     struct MockBackend;
 
     impl KvsBackend for MockBackend {