-
Notifications
You must be signed in to change notification settings - Fork 21
impl: broken examples bugfix #186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
impl: broken examples bugfix #186
Conversation
Examples were no longer working correctly after recent changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes broken examples by updating them to reflect recent changes in the KVS library. The changes ensure that example code properly handles default file creation with hash validation and simplifies KVS builder initialization.
Key changes:
- Added hash file generation for default values in the defaults example
- Removed explicit
KvsLoadconfiguration from basic example builder calls
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/rust/rust_kvs/examples/defaults.rs | Adds hash file creation alongside the default JSON file to support hash validation |
| src/rust/rust_kvs/examples/basic.rs | Simplifies KVS builder initialization by removing explicit kvs_load parameter settings |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
License Check Results🚀 The license check job ran with the Bazel command: bazel run //:license-checkStatus: Click to expand output |
|
The created documentation from the pull request is available at: docu-html |
Examples were no longer working correctly after recent changes.