-
Notifications
You must be signed in to change notification settings - Fork 23
bazel: Replace crate extension with score-crates #193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bazel: Replace crate extension with score-crates #193
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR refactors the Bazel build configuration by replacing the crate_universe extension with a centralized score-crates dependency. The changes streamline dependency management by moving from workspace-specific crate resolution to a shared crate repository.
Key changes:
- Replaced
crate_universeextension configuration withscore_cratesBazel dependency - Updated function signatures to change
input: Option<String>toinput: &stracross test scenarios - Added tracing infrastructure with custom Unix timestamp formatter in the main entry point
Reviewed changes
Copilot reviewed 12 out of 13 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| MODULE.bazel | Removed crate_universe extension configuration and added score_crates dependency with git override |
| src/rust/rust_kvs/BUILD | Replaced all_crate_deps() with explicit crate dependencies from @score_crates |
| src/rust/rust_kvs_tool/BUILD | Replaced all_crate_deps() with explicit crate dependencies from @score_crates |
| tests/rust_test_scenarios/BUILD | Replaced all_crate_deps() and workspace crate references with explicit @score_crates dependencies |
| tests/rust_test_scenarios/Cargo.toml | Updated test_scenarios_rust dependency to use eclipse-score GitHub organization and v0.3.0 |
| tests/rust_test_scenarios/src/main.rs | Added tracing subscriber initialization with custom Unix timestamp formatter and changed main return type |
| tests/rust_test_scenarios/src/test_basic.rs | Changed run() method signature from Option<String> to &str and removed unnecessary unwrap logic |
| tests/rust_test_scenarios/src/cit/supported_datatypes.rs | Changed run() method signatures from Option<String> to &str and removed unnecessary unwrap logic |
| tests/rust_test_scenarios/src/cit/snapshots.rs | Changed run() method signatures from Option<String> to &str and removed unnecessary unwrap logic |
| tests/rust_test_scenarios/src/cit/persistency.rs | Changed run() method signature from Option<String> to &str and removed unnecessary unwrap logic |
| tests/rust_test_scenarios/src/cit/multiple_kvs.rs | Changed run() method signatures from Option<String> to &str and removed unnecessary unwrap logic |
| tests/rust_test_scenarios/src/cit/default_values.rs | Changed run() method signatures from Option<String> to &str and removed unnecessary unwrap logic |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
License Check Results🚀 The license check job ran with the Bazel command: bazel run //:license-checkStatus: Click to expand output |
|
The created documentation from the pull request is available at: docu-html |
46428ac to
f926c19
Compare
vbogdanb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
f926c19 to
15d96ed
Compare
|
Rebased and removed git_override for score_crates |
15d96ed to
2e8a4f6
Compare
No description provided.