Skip to content

Conversation

@igorostrowskiq
Copy link
Contributor

No description provided.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the Bazel build configuration by replacing the crate_universe extension with a centralized score-crates dependency. The changes streamline dependency management by moving from workspace-specific crate resolution to a shared crate repository.

Key changes:

  • Replaced crate_universe extension configuration with score_crates Bazel dependency
  • Updated function signatures to change input: Option<String> to input: &str across test scenarios
  • Added tracing infrastructure with custom Unix timestamp formatter in the main entry point

Reviewed changes

Copilot reviewed 12 out of 13 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
MODULE.bazel Removed crate_universe extension configuration and added score_crates dependency with git override
src/rust/rust_kvs/BUILD Replaced all_crate_deps() with explicit crate dependencies from @score_crates
src/rust/rust_kvs_tool/BUILD Replaced all_crate_deps() with explicit crate dependencies from @score_crates
tests/rust_test_scenarios/BUILD Replaced all_crate_deps() and workspace crate references with explicit @score_crates dependencies
tests/rust_test_scenarios/Cargo.toml Updated test_scenarios_rust dependency to use eclipse-score GitHub organization and v0.3.0
tests/rust_test_scenarios/src/main.rs Added tracing subscriber initialization with custom Unix timestamp formatter and changed main return type
tests/rust_test_scenarios/src/test_basic.rs Changed run() method signature from Option<String> to &str and removed unnecessary unwrap logic
tests/rust_test_scenarios/src/cit/supported_datatypes.rs Changed run() method signatures from Option<String> to &str and removed unnecessary unwrap logic
tests/rust_test_scenarios/src/cit/snapshots.rs Changed run() method signatures from Option<String> to &str and removed unnecessary unwrap logic
tests/rust_test_scenarios/src/cit/persistency.rs Changed run() method signature from Option<String> to &str and removed unnecessary unwrap logic
tests/rust_test_scenarios/src/cit/multiple_kvs.rs Changed run() method signatures from Option<String> to &str and removed unnecessary unwrap logic
tests/rust_test_scenarios/src/cit/default_values.rs Changed run() method signatures from Option<String> to &str and removed unnecessary unwrap logic

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link

github-actions bot commented Dec 11, 2025

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run //:license-check

Status: ⚠️ Needs Review

Click to expand output
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.3.0) and connecting to it...
INFO: Invocation ID: b848ad99-aa1f-4a42-97ed-4dd62184533c
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
DEBUG: Rule 'rust_qnx8_toolchain+' indicated that a canonical reproducible form can be obtained by modifying arguments integrity = "sha256-oEubHgeZDdT0svMmBKJx7c3/2TdSI/vfwRUyDn+TPGA="
DEBUG: Repository rust_qnx8_toolchain+ instantiated at:
  <builtin>: in <toplevel>
Repository rule http_archive defined at:
  /home/runner/.bazel/external/bazel_tools/tools/build_defs/repo/http.bzl:394:31: in <toplevel>
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 5 packages loaded
Loading: 5 packages loaded
    currently loading: 
Analyzing: target //:license-check (6 packages loaded, 0 targets configured)
Analyzing: target //:license-check (6 packages loaded, 0 targets configured)

Analyzing: target //:license-check (88 packages loaded, 10 targets configured)

Analyzing: target //:license-check (91 packages loaded, 10 targets configured)

Analyzing: target //:license-check (91 packages loaded, 10 targets configured)

Analyzing: target //:license-check (151 packages loaded, 2816 targets configured)

Analyzing: target //:license-check (157 packages loaded, 2965 targets configured)

INFO: Analyzed target //:license-check (165 packages loaded, 5030 targets configured).
[3 / 14] [Prepa] Creating source manifest for @@score_tooling+//dash/tool/formatters:dash_format_converter [for tool] ... (2 actions, 0 running)
INFO: From Generating Dash formatted dependency file ...:
INFO: Successfully converted 62 packages from Cargo.lock to bazel-out/k8-fastbuild/bin/formatted.txt
INFO: Found 1 target...
Target //:license.check.license_check up-to-date:
  bazel-bin/license.check.license_check
  bazel-bin/license.check.license_check.jar
INFO: Elapsed time: 22.810s, Critical Path: 0.32s
INFO: 14 processes: 5 disk cache hit, 9 internal.
INFO: Build completed successfully, 14 total actions
INFO: Running command line: bazel-bin/license.check.license_check ./formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

@github-actions
Copy link

The created documentation from the pull request is available at: docu-html

@igorostrowskiq igorostrowskiq force-pushed the igorostrowskiq_replace_crate_with_score_crates branch 2 times, most recently from 46428ac to f926c19 Compare December 11, 2025 15:25
Copy link
Contributor

@vbogdanb vbogdanb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@igorostrowskiq igorostrowskiq force-pushed the igorostrowskiq_replace_crate_with_score_crates branch from f926c19 to 15d96ed Compare December 15, 2025 12:46
@igorostrowskiq
Copy link
Contributor Author

Rebased and removed git_override for score_crates

@igorostrowskiq igorostrowskiq force-pushed the igorostrowskiq_replace_crate_with_score_crates branch from 15d96ed to 2e8a4f6 Compare December 16, 2025 11:00
@pawelrutkaq pawelrutkaq merged commit f9ba985 into eclipse-score:main Dec 16, 2025
14 checks passed
@igorostrowskiq igorostrowskiq deleted the igorostrowskiq_replace_crate_with_score_crates branch December 16, 2025 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants