test: switch to rules_lint #238

dcalavrezo-qorix · 2026-02-03T14:02:43Z

switched clippy to rules lint

github-actions · 2026-02-03T14:03:46Z

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run //:license-check

Status: ⚠️ Needs Review

Click to expand output

[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.3.0) and connecting to it...
INFO: Invocation ID: 2c6715eb-c1d1-43f2-bf2e-1bd195693d1f
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
WARNING: For repository 'rules_rust', the root module requires module version [email protected], but got [email protected] in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'rules_cc', the root module requires module version [email protected], but got [email protected] in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'score_bazel_platforms', the root module requires module version [email protected], but got [email protected] in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'score_process', the root module requires module version [email protected], but got [email protected] in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 2 packages loaded
Loading: 2 packages loaded
    currently loading: 
Loading: 2 packages loaded
    currently loading: 
Analyzing: target //:license-check (3 packages loaded)
Analyzing: target //:license-check (3 packages loaded, 0 targets configured)
Analyzing: target //:license-check (3 packages loaded, 0 targets configured)

Analyzing: target //:license-check (20 packages loaded, 10 targets configured)

Analyzing: target //:license-check (72 packages loaded, 10 targets configured)

Analyzing: target //:license-check (82 packages loaded, 10 targets configured)

Analyzing: target //:license-check (88 packages loaded, 10 targets configured)

Analyzing: target //:license-check (152 packages loaded, 2060 targets configured)

Analyzing: target //:license-check (157 packages loaded, 2077 targets configured)

Analyzing: target //:license-check (157 packages loaded, 2077 targets configured)

Analyzing: target //:license-check (160 packages loaded, 4084 targets configured)

Analyzing: target //:license-check (163 packages loaded, 4600 targets configured)

Analyzing: target //:license-check (164 packages loaded, 9234 targets configured)

Analyzing: target //:license-check (165 packages loaded, 9242 targets configured)

Analyzing: target //:license-check (165 packages loaded, 9242 targets configured)

Analyzing: target //:license-check (168 packages loaded, 9378 targets configured)
[8 / 14] Creating runfiles tree bazel-out/k8-opt-exec-ST-d57f47055a04/bin/external/score_tooling+/dash/tool/formatters/dash_format_converter.runfiles [for tool]; 0s local ... (2 actions, 1 running)
Analyzing: target //:license-check (187 packages loaded, 9439 targets configured)
[10 / 14] JavaToolchainCompileClasses external/rules_java+/toolchains/platformclasspath_classes; 0s disk-cache, processwrapper-sandbox ... (2 actions running)
INFO: From Generating Dash formatted dependency file ...:
INFO: Successfully converted 62 packages from Cargo.lock to bazel-out/k8-fastbuild/bin/formatted.txt
Analyzing: target //:license-check (191 packages loaded, 9450 targets configured)
[11 / 14] JavaToolchainCompileClasses external/rules_java+/toolchains/platformclasspath_classes; 1s disk-cache, processwrapper-sandbox
Analyzing: target //:license-check (191 packages loaded, 9450 targets configured)
[12 / 14] JavaToolchainCompileBootClasspath external/rules_java+/toolchains/platformclasspath.jar; 0s disk-cache, processwrapper-sandbox
Analyzing: target //:license-check (191 packages loaded, 9450 targets configured)
[14 / 14] no actions running
Analyzing: target //:license-check (191 packages loaded, 9450 targets configured)
[14 / 14] no actions running
Analyzing: target //:license-check (192 packages loaded, 13784 targets configured)
[14 / 14] no actions running
Analyzing: target //:license-check (192 packages loaded, 13784 targets configured)
[14 / 14] no actions running
Analyzing: target //:license-check (192 packages loaded, 13784 targets configured)
[14 / 14] no actions running
Analyzing: target //:license-check (192 packages loaded, 13784 targets configured)
[14 / 14] no actions running
Analyzing: target //:license-check (192 packages loaded, 13784 targets configured)
[14 / 14] no actions running
Analyzing: target //:license-check (192 packages loaded, 13784 targets configured)
[14 / 14] no actions running
INFO: Analyzed target //:license-check (195 packages loaded, 13889 targets configured).
INFO: Found 1 target...
Target //:license.check.license_check up-to-date:
  bazel-bin/license.check.license_check
  bazel-bin/license.check.license_check.jar
INFO: Elapsed time: 55.854s, Critical Path: 4.43s
INFO: 14 processes: 9 internal, 4 processwrapper-sandbox, 1 worker.
INFO: Build completed successfully, 14 total actions
INFO: Running command line: bazel-bin/license.check.license_check ./formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

github-actions · 2026-02-03T14:10:31Z

The created documentation from the pull request is available at: docu-html

switched clippy to rules lint Signed-off-by: Dan Calavrezo <[email protected]>

MaximilianSoerenPollak

Just two questions

MaximilianSoerenPollak · 2026-02-04T09:40:38Z

.github/workflows/clippy.yml

    uses: eclipse-score/cicd-workflows/.github/workflows/static-analysis.yml@main
    with:
-      bazel-target: "build //:clippy"
+      bazel-targets: "//src/rust/..."


Is this 'targets' or a typo? As it was 'target' before?

no, it is targets now

you must have 20/20 vision, Max 😄

MaximilianSoerenPollak · 2026-02-04T09:42:56Z

src/rust/rust_kvs/src/kvs_serialize.rs

+        assert!(result
+            .is_err_and(|e| e == ErrorCode::DeserializationFailed("Invalid KvsValue variant provided".to_string())));


Does this work

result .something

Can the '.' operator be split on newlines like that?

this is fixed by the rustfmt, I don't want to mess it up

removed cargo fmt execution from workflows Signed-off-by: Dan Calavrezo <[email protected]>

vinodreddy-g

LGTM

dcalavrezo-qorix requested review from PandaeDo and vinodreddy-g as code owners February 3, 2026 14:02

dcalavrezo-qorix force-pushed the dcalavrezo_clippy_lint branch from eb25bb1 to d2aca3d Compare February 3, 2026 15:36

clippy: switch to rules_lint

788f512

switched clippy to rules lint Signed-off-by: Dan Calavrezo <[email protected]>

dcalavrezo-qorix force-pushed the dcalavrezo_clippy_lint branch from 90bb5c8 to 788f512 Compare February 4, 2026 09:14

PandaeDo requested a review from MaximilianSoerenPollak February 4, 2026 09:26

MaximilianSoerenPollak reviewed Feb 4, 2026

View reviewed changes

fmt: removed fmt execution

1b21dbb

removed cargo fmt execution from workflows Signed-off-by: Dan Calavrezo <[email protected]>

vinodreddy-g reviewed Feb 4, 2026

View reviewed changes

vinodreddy-g approved these changes Feb 4, 2026

View reviewed changes

vinodreddy-g merged commit 5d9f822 into main Feb 4, 2026
18 checks passed

vinodreddy-g deleted the dcalavrezo_clippy_lint branch February 4, 2026 12:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: switch to rules_lint #238

test: switch to rules_lint #238

Uh oh!

dcalavrezo-qorix commented Feb 3, 2026

Uh oh!

github-actions bot commented Feb 3, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Feb 3, 2026

Uh oh!

MaximilianSoerenPollak left a comment

Uh oh!

MaximilianSoerenPollak Feb 4, 2026

Uh oh!

dcalavrezo-qorix Feb 4, 2026

Uh oh!

dcalavrezo-qorix Feb 4, 2026

Uh oh!

MaximilianSoerenPollak Feb 4, 2026

Uh oh!

dcalavrezo-qorix Feb 4, 2026

Uh oh!

vinodreddy-g left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		assert!(result
		.is_err_and(\|e\| e == ErrorCode::DeserializationFailed("Invalid KvsValue variant provided".to_string())));

test: switch to rules_lint #238

test: switch to rules_lint #238

Uh oh!

Conversation

dcalavrezo-qorix commented Feb 3, 2026

Uh oh!

github-actions bot commented Feb 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

License Check Results

Uh oh!

github-actions bot commented Feb 3, 2026

Uh oh!

MaximilianSoerenPollak left a comment

Choose a reason for hiding this comment

Uh oh!

MaximilianSoerenPollak Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

dcalavrezo-qorix Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

dcalavrezo-qorix Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

MaximilianSoerenPollak Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

dcalavrezo-qorix Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

vinodreddy-g left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions bot commented Feb 3, 2026 •

edited

Loading