test: execute CIT with Bazel by PiotrKorkus · Pull Request #48 · eclipse-score/persistency

PiotrKorkus · 2025-07-16T11:52:51Z

deleted kvs_0_default.json - it is created by the test in tempdir, no need to keep it in repo
fixed rust_library target after split
added targets for CIT and grouped them under one test suite

Note:
Bazel requires one test target per integration test file to match Cargo’s behavior. This is why you can’t use a single glob for all cit_.rs files in one rust_test target. If you use glob(["tests/cit_*.rs"]) as srcs in a single rust_test, Bazel tries to build all those files as one crate, but there’s no single crate root, so it fails with errors like “Couldn't find lib.rs”.

github-actions · 2025-07-16T11:56:26Z

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run //:license-check

Status: ⚠️ Needs Review

Click to expand output

[License Check Output]
Extracting Bazel installation...
Starting local Bazel server and connecting to it...
INFO: Invocation ID: 22e380b1-61d4-4ee3-9a16-e76f2d432911
Computing main repo mapping: 
Computing main repo mapping: 
DEBUG: Rule 'rules_boost~' indicated that a canonical reproducible form can be obtained by modifying arguments integrity = "sha256-aSViuHoOdF32Ue/Cx02/mOzyEebHMFuifjZs4GNWjsE="
DEBUG: Repository rules_boost~ instantiated at:
  <builtin>: in <toplevel>
Repository rule http_archive defined at:
  /home/runner/.bazel/external/bazel_tools/tools/build_defs/repo/http.bzl:387:31: in <toplevel>
Computing main repo mapping: 
WARNING: For repository 'googletest', the root module requires module version googletest@1.14.0, but got googletest@1.15.0 in the resolved dependency graph.
WARNING: For repository 'aspect_rules_lint', the root module requires module version aspect_rules_lint@1.0.3, but got aspect_rules_lint@1.4.2 in the resolved dependency graph.
Computing main repo mapping: 
Loading: 
Loading: 1 packages loaded
Analyzing: target //:license-check (2 packages loaded, 0 targets configured)
Analyzing: target //:license-check (2 packages loaded, 0 targets configured)

Analyzing: target //:license-check (55 packages loaded, 10 targets configured)

Analyzing: target //:license-check (99 packages loaded, 10 targets configured)

Analyzing: target //:license-check (107 packages loaded, 10 targets configured)

Analyzing: target //:license-check (107 packages loaded, 10 targets configured)

Analyzing: target //:license-check (157 packages loaded, 972 targets configured)

Analyzing: target //:license-check (165 packages loaded, 2810 targets configured)

Analyzing: target //:license-check (165 packages loaded, 2810 targets configured)

Analyzing: target //:license-check (168 packages loaded, 4816 targets configured)

Analyzing: target //:license-check (170 packages loaded, 5060 targets configured)

Analyzing: target //:license-check (170 packages loaded, 5060 targets configured)

Analyzing: target //:license-check (170 packages loaded, 5060 targets configured)

INFO: Analyzed target //:license-check (171 packages loaded, 6979 targets configured).
[8 / 13] [Prepa] Expanding template license.check.license_check
ERROR: /home/runner/work/inc_mw_per/inc_mw_per/BUILD:36:21: Generating Dash formatted dependency file ... failed: missing input file '//:cargo_lock'
ERROR: /home/runner/work/inc_mw_per/inc_mw_per/BUILD:36:21: Generating Dash formatted dependency file ... failed: 1 input file(s) do not exist
Target //:license.check.license_check failed to build
Use --verbose_failures to see the command lines of failed build steps.
ERROR: /home/runner/work/inc_mw_per/inc_mw_per/BUILD:36:21 Generating Dash formatted dependency file ... failed: 1 input file(s) do not exist
INFO: Elapsed time: 188.622s, Critical Path: 0.33s
INFO: 12 processes: 2 disk cache hit, 10 internal.
ERROR: Build did NOT complete successfully
ERROR: Build failed. Not running target

github-actions · 2025-07-16T11:58:01Z

The created documentation from the pull request is available at: docu-html

arkjedrz · 2025-07-22T17:20:53Z

src/rust/rust_kvs/tests/README.md

 All tests are kept in separate files as the working directory is always
 changed. If there is more than one test in a file both tests are run in
 parallel and use the same working directory which will led to wrong results.
+


TBH I think it'd be better to remove this README.md file and add a proper one to the root of repository.

This README.md doesn't contain anything useful.

It's better to have all basic information in one place.

You can copy the one from orch repo, with minor changes it should do just fine.

done, please check new readme

src/rust/rust_kvs/BUILD

arkjedrz · 2025-07-23T06:23:44Z

src/rust/rust_kvs/BUILD

+    deps = __cit_deps,
+)
+
+rust_test(


I'm not fond of having a target for every file, but TBH couldn't find a way to do it better without breaking existing cargo test runs.

me too, so far the only way I found to group tests is by using test suite and I think this will be our way of running all component tests at once:
bazel test //src/rust/rust_kvs:cit

Created bazel targets for component integration tests. Groupped them under one test suite.

enable autoformatting bazel files on save

README.md

arkjedrz · 2025-07-23T12:19:05Z

README.md

+
+```bash
+sudo apt-get update
+sudo apt-get install -y curl build-essential protobuf-compiler libclang-dev


Did You check those deps are relevant?

yes, I checked it out in docker

arkjedrz · 2025-07-23T12:19:57Z

README.md

+Build all targets:
+
+```bash
+bazel build //...


I'm not sure if this will work in this repo right now.

Docs are the only that don't. But in general that command shall be always working. Created ticket - #52

README.md

arkjedrz · 2025-07-23T12:23:35Z

README.md

+```bash
+cargo run --help
+```
+```


Add text and blank line:

https://github.com/DavidAnson/markdownlint/blob/v0.38.0/doc/md040.md

https://github.com/DavidAnson/markdownlint/blob/v0.38.0/doc/md031.md

README.md

moved to project root added info about bazel, cargo, testing and cli tool

arkjedrz · 2025-07-23T17:19:37Z

LGTM

…bazel test: execute CIT with Bazel

PiotrKorkus force-pushed the piotrkorkus_cit_bazel branch from 1aac2f5 to 2b190f9 Compare July 16, 2025 11:55

PiotrKorkus force-pushed the piotrkorkus_cit_bazel branch from 2b190f9 to e283498 Compare July 16, 2025 14:07

PiotrKorkus requested review from arkjedrz, draganbjedov, igorostrowskiq and vinodreddy-g July 16, 2025 15:32

arkjedrz requested changes Jul 23, 2025

View reviewed changes

PiotrKorkus added 2 commits July 23, 2025 09:11

test: execute CIT with Bazel

05b5ee8

Created bazel targets for component integration tests. Groupped them under one test suite.

bazel: add starlark language server

d384aee

enable autoformatting bazel files on save

PiotrKorkus force-pushed the piotrkorkus_cit_bazel branch from e283498 to f3ea1d4 Compare July 23, 2025 07:38

arkjedrz requested changes Jul 23, 2025

View reviewed changes

doc: improve readme

eb2fdea

moved to project root added info about bazel, cargo, testing and cli tool

PiotrKorkus force-pushed the piotrkorkus_cit_bazel branch from f3ea1d4 to eb2fdea Compare July 23, 2025 14:03

arkjedrz approved these changes Jul 23, 2025

View reviewed changes

vinodreddy-g approved these changes Jul 28, 2025

View reviewed changes

vinodreddy-g merged commit 3e664ce into eclipse-score:main Jul 28, 2025
11 checks passed

atarekra pushed a commit to Valeo-S-CORE-Organization/persistency that referenced this pull request Nov 9, 2025

Merge pull request eclipse-score#48 from qorix-group/piotrkorkus_cit_…

3a9f555

…bazel test: execute CIT with Bazel

Conversation

PiotrKorkus commented Jul 16, 2025

Uh oh!

github-actions bot commented Jul 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

License Check Results

Uh oh!

github-actions bot commented Jul 16, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

arkjedrz commented Jul 23, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions bot commented Jul 16, 2025 •

edited

Loading