CPP: Support basic types + Add Dir Parameter #54
Merged
vinodreddy-g merged 10 commits intoeclipse-score:mainfrom Jul 30, 2025
Merged
CPP: Support basic types + Add Dir Parameter #54vinodreddy-g merged 10 commits intoeclipse-score:mainfrom
vinodreddy-g merged 10 commits intoeclipse-score:mainfrom
Conversation
Implement datatypes and add a DIR parameter to align with Rust (+Unittests)
cpp tests: move test-dir to src/cpp/tests/ and update bazel files
License Check Results🚀 The license check job ran with the Bazel command: bazel run //:license-checkStatus: Click to expand output |
|
The created documentation from the pull request is available at: docu-html |
Add InvalidArgument errorcode, if dir argument is invalid
Update json datatype format + unittests + prepare json mock library usage
remove stubs and include the json lib mocking methods
This was referenced Jul 28, 2025
remove capital letters in number datatypes enum
remove write_json_data buffer argument
umaucher
requested changes
Jul 29, 2025
score::filesystem::Path implemented and unittests updated to use score fs mock
d7a2658 to
42da45e
Compare
Update impl and tests BUILD Files and Workflow
remove InvalidArgument, since its no longer used
umaucher
approved these changes
Jul 30, 2025
vinodreddy-g
approved these changes
Jul 30, 2025
atarekra
pushed a commit
to Valeo-S-CORE-Organization/persistency
that referenced
this pull request
Nov 9, 2025
CPP: Support basic types + Add Dir Parameter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains:
(Also add Copyright Header for workflows in bm_kvs.cpp)
To Do before merging:
--> ✅ Aligned with @vinodreddy-g (28.07.2025): Format from this comment will be used.
All Unittests were updated to the changes from this PR to stay with 100% Branches, 100% Functions and 100% Lines
(only the brackets in the kvsvalue_to_any switch case stay falsely reported as not hit)
Also the Any Stub is no longer needed for reaching the error case in any_to_kvsvalue, all stubs are removed and the dependency to the mock json parser/writer is used
Code Coverage Report: coverage.zip