Process description safety analysis takeover from old process repository #20
Conversation
|
The created documentation from the pull request is available at: docu-html |
aschemmel-tech
left a comment
aschemmel-tech
left a comment
There was a problem hiding this comment.
Reviewed corrections based on findings from eclipse-score/score#902
process/process_areas/safety_analysis/safety_analysis_concept.rst
Outdated
Show resolved
Hide resolved
process/process_areas/safety_analysis/safety_analysis_workflow.rst
Outdated
Show resolved
Hide resolved
process/process_areas/safety_analysis/guidance/safety_analysis_process_reqs.rst
Outdated
Show resolved
Hide resolved
process/process_areas/safety_analysis/guidance/safety_analysis_process_reqs.rst
Outdated
Show resolved
Hide resolved
process/process_areas/safety_analysis/guidance/safety_analysis_process_reqs.rst
Outdated
Show resolved
Hide resolved
process/process_areas/safety_analysis/safety_analysis_roles.rst
Outdated
Show resolved
Hide resolved
process/process_areas/safety_analysis/safety_analysis_roles.rst
Outdated
Show resolved
Hide resolved
process/process_areas/safety_analysis/safety_analysis_roles.rst
Outdated
Show resolved
Hide resolved
process/process_areas/safety_analysis/safety_analysis_roles.rst
Outdated
Show resolved
Hide resolved
process/process_areas/safety_analysis/safety_analysis_workproducts.rst
Outdated
Show resolved
Hide resolved
masc2023
left a comment
masc2023
left a comment
There was a problem hiding this comment.
Please generate a new documentation, when you have finished resolving all findings
| .. figure:: _assets/safety_analysis_workflow.drawio.svg | ||
| :align: center | ||
| :width: 80% | ||
| :name: safety_analysis_workflow_fig |
There was a problem hiding this comment.
the image mentions a platform architecture wp, what is that, not defined. As discussed today, we may introduce an static overview image, currently defined as roadmap, and call that platform architecture, and a dependency graph, which is the basis for that defined platform feature dfa?
What about the numbers, are they explained somewhere? What are the relationship workflow names? Workflows are only called Analyse something, but Perform is not there, so can they be deleted?
There was a problem hiding this comment.
Changed it in that way that I used the discussed description as platform feature architecture
process/process_areas/safety_analysis/safety_analysis_getstrt.rst
Outdated
Show resolved
Hide resolved
| Detailed description which steps are need for a safety analysis. In general the workflow is shown in :ref:`safety_analysis_workflow_fig` | ||
|
|
||
| #. To analyse the Platform Architecture DFA shall be executed. | ||
| #. Perform DFA on the Platform Architecture. |
There was a problem hiding this comment.
I would scale down these points to the workflows defined, so perform does not exists, remove it is done during analysis anyhow or not?
There was a problem hiding this comment.
Changed description as discussed. Orientated on the structure of requirements engineering
process/process_areas/safety_analysis/guidance/safety_analysis_guideline.rst
Outdated
Show resolved
Hide resolved
process/process_areas/safety_analysis/guidance/safety_analysis_guideline.rst
Outdated
Show resolved
Hide resolved
process/process_areas/safety_analysis/guidance/safety_analysis_guideline.rst
Outdated
Show resolved
Hide resolved
process/process_areas/safety_analysis/guidance/safety_analysis_guideline.rst
Outdated
Show resolved
Hide resolved
process/process_areas/safety_analysis/guidance/safety_analysis_process_reqs.rst
Outdated
Show resolved
Hide resolved
process/process_areas/safety_analysis/guidance/safety_analysis_process_reqs.rst
Show resolved
Hide resolved
|
@PandaeDo , @aschemmel-tech , are the activities for Safety Analysis covered by the Safety Management Plan? If yes, some comments, hints should be added |
PandaeDo
force-pushed
the
vohae_safety_analysis
branch
from
d54b0be to
878fce2
Compare
aschemmel-tech
left a comment
aschemmel-tech
left a comment
There was a problem hiding this comment.
most findings resolved, some additional remarks added
process/process_areas/safety_analysis/guidance/safety_analysis_process_reqs.rst
Outdated
Show resolved
Hide resolved
process/process_areas/safety_analysis/guidance/safety_analysis_process_reqs.rst
Outdated
Show resolved
Hide resolved
process/process_areas/safety_analysis/guidance/safety_analysis_process_reqs.rst
Outdated
Show resolved
Hide resolved
process/process_areas/safety_analysis/guidance/safety_analysis_process_reqs.rst
Outdated
Show resolved
Hide resolved
process/process_areas/safety_analysis/guidance/safety_analysis_guideline.rst
Outdated
Show resolved
Hide resolved
process/process_areas/safety_analysis/safety_analysis_concept.rst
Outdated
Show resolved
Hide resolved
process/process_areas/safety_analysis/guidance/safety_analysis_process_reqs.rst
Outdated
Show resolved
Hide resolved
process/process_areas/safety_analysis/safety_analysis_roles.rst
Outdated
Show resolved
Hide resolved
process/process_areas/safety_analysis/safety_analysis_workflow.rst
Outdated
Show resolved
Hide resolved
process/process_areas/safety_analysis/safety_analysis_workflow.rst
Outdated
Show resolved
Hide resolved
aschemmel-tech
left a comment
aschemmel-tech
left a comment
There was a problem hiding this comment.
All good now from my side
PandaeDo
force-pushed
the
vohae_safety_analysis
branch
from
5f8624e to
3d62557
Compare
process/process_areas/safety_analysis/guidance/safety_analysis_guideline.rst
Outdated
Show resolved
Hide resolved
| The analysis starts at feature level. With a DFA shall be analysed if there are dependent failures which have to be considered. The analysis | ||
| shall be done in the way that we use the static and dynamic diagrams. The following picture shall show the perspective of the User. | ||
|
|
||
| .. _safety_analysis_feature_example: |
There was a problem hiding this comment.
Does the Key not found error not require a message before, e.g. get key?
There was a problem hiding this comment.
We have seven dynamic diagrams for kvs. I picked a simple one for the example to show how the analysis shall be done.
masc2023
left a comment
masc2023
left a comment
There was a problem hiding this comment.
At least the missing work product, workflow should be added before initial merge
CI/CD workflows changed, adapting to changes there. Increasing docs-as-code to get various bugfixes.
Ref: closes #310 process: switch process description of safety analysis to process_description process: rebase Ref: closes #310 process: solve building error Ref: closes #310 process: including actual review findings. clearance of platform level after decission Ref: closes #316 process: review process: include review findings Ref: closes #316 process: fix building errors Ref: closes #316 process: include review finding Ref: closes #316 process: include review findings Ref: closes #310 process: include review findings Ref: closes #310
Ref: closes #310
Ref: closes #310
Ref: closes #310
PandaeDo
force-pushed
the
vohae_safety_analysis
branch
from
fc91db0 to
1d644b3
Compare
masc2023
left a comment
masc2023
left a comment
There was a problem hiding this comment.
Fine for the first, initial version
4 participants
No description provided.