Skip to content

Conversation

@aschemmel-tech
Copy link
Contributor

@aschemmel-tech aschemmel-tech commented Dec 10, 2025

Resolves: #78

  • Remove status and issues from module safety plan template
  • Correct responsibility for FDR reports
  • Fix some findings from updating the status, e.g. move Detailed Design template to folder_templates

Related to: eclipse-score/score#2325

@github-actions
Copy link

The created documentation from the pull request is available at: docu-html

@aschemmel-tech aschemmel-tech force-pushed the aschemmel-tech-module-safety-status branch from 1d85851 to 144586d Compare December 10, 2025 15:25
@pahmann
Copy link
Member

pahmann commented Dec 11, 2025

A minor remark. The description of the Pull Request and the commit messages should describe what the change is about. This is described in https://eclipse-score.github.io/score/main/contribute/general/git.html#git-guidelines

I would expect that this change would simply update the status of the module safety plan, but there are more code changes. Consider to describe in the PR heading and description what is contained.

@aschemmel-tech aschemmel-tech force-pushed the aschemmel-tech-module-safety-status branch 2 times, most recently from beaa47a to 367c737 Compare December 11, 2025 12:33
@aschemmel-tech aschemmel-tech changed the title Module Safety plan status updates Module Safety plan status and role updates Dec 11, 2025
-
* - IMPL_02_03
- Are detailed design and source code consistent?
- Check if the static and dynamic design descriptions match the code (e..g. naming of elements)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo e.g.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

corrected

* - IMPL_02_03
- Are detailed design and source code consistent?
- Check if the static and dynamic design descriptions match the code (e..g. naming of elements)
and that the respective traceability is established (doxygen style comments)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

e.g. doxygen as example

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed this

-
* - IMPL_02_02
- Do manual checks, that are derived from the coding guideline, find no safety critical error?
- Check this list for C++ <link> and this list for Rust <link>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

example, e.g. for programming languages used, C++ or Rust

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reformulated

* - IMPL_01_04
- Are all external libraries used by the component specified in the detailed design?
- Check the automated dependency analysis.
Also make sure ASIL rated units also only use ASIL or FFI rated libraries.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have defined FFI rated libraries somewhere?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, removed FFI

:input: wp__platform_mgmt, wp__issue_track_system, wp__sw_component_class, wp__tailoring
:output: wp__module_safety_plan, wp__platform_safety_plan
:input: wp__platform_mgmt, wp__issue_track_system, wp__sw_component_class, wp__tailoring_work_products
:output: wp__module_safety_plan, wp__platform_safety_plan, wp__tailoring
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here wp__tailoring_safety, as we may have others, e.g. security

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

renamed to wp_safety_tailoring

Copy link
Contributor

@masc2023 masc2023 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments, at least tools should be stated as examples only

PandaeDo
PandaeDo previously approved these changes Dec 12, 2025
@masc2023 masc2023 merged commit 62c66fb into main Dec 12, 2025
5 checks passed
@masc2023 masc2023 deleted the aschemmel-tech-module-safety-status branch December 12, 2025 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Audit preparation: Safety Management

5 participants