-
Notifications
You must be signed in to change notification settings - Fork 16
Module Safety plan status and role updates #447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The created documentation from the pull request is available at: docu-html |
1d85851 to
144586d
Compare
|
A minor remark. The description of the Pull Request and the commit messages should describe what the change is about. This is described in https://eclipse-score.github.io/score/main/contribute/general/git.html#git-guidelines I would expect that this change would simply update the status of the module safety plan, but there are more code changes. Consider to describe in the PR heading and description what is contained. |
beaa47a to
367c737
Compare
367c737 to
9d281d6
Compare
| - | ||
| * - IMPL_02_03 | ||
| - Are detailed design and source code consistent? | ||
| - Check if the static and dynamic design descriptions match the code (e..g. naming of elements) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo e.g.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
corrected
process/process_areas/process_management/process_management_workflow.rst
Show resolved
Hide resolved
| * - IMPL_02_03 | ||
| - Are detailed design and source code consistent? | ||
| - Check if the static and dynamic design descriptions match the code (e..g. naming of elements) | ||
| and that the respective traceability is established (doxygen style comments) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
e.g. doxygen as example
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed this
| - | ||
| * - IMPL_02_02 | ||
| - Do manual checks, that are derived from the coding guideline, find no safety critical error? | ||
| - Check this list for C++ <link> and this list for Rust <link> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
example, e.g. for programming languages used, C++ or Rust
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reformulated
| * - IMPL_01_04 | ||
| - Are all external libraries used by the component specified in the detailed design? | ||
| - Check the automated dependency analysis. | ||
| Also make sure ASIL rated units also only use ASIL or FFI rated libraries. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have defined FFI rated libraries somewhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, removed FFI
| :input: wp__platform_mgmt, wp__issue_track_system, wp__sw_component_class, wp__tailoring | ||
| :output: wp__module_safety_plan, wp__platform_safety_plan | ||
| :input: wp__platform_mgmt, wp__issue_track_system, wp__sw_component_class, wp__tailoring_work_products | ||
| :output: wp__module_safety_plan, wp__platform_safety_plan, wp__tailoring |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here wp__tailoring_safety, as we may have others, e.g. security
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
renamed to wp_safety_tailoring
masc2023
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments, at least tools should be stated as examples only
Resolves: #78
Related to: eclipse-score/score#2325