process: improve process description safety analysis #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
The created documentation from the pull request is available at: docu-html |
masc2023
reviewed
Jun 30, 2025
process/process_areas/safety_analysis/_assets/safety_analysis_workflow.drawio.svg
Outdated
Show resolved
Hide resolved
Contributor
MaximilianSoerenPollak
left a comment
MaximilianSoerenPollak
left a comment
There was a problem hiding this comment.
Some comments from my side.
process/folder_templates/modules/module_name/component_name/docs/safety_analysis/dfa.rst
Outdated
Show resolved
Hide resolved
process/folder_templates/modules/module_name/component_name/docs/safety_analysis/fmea.rst
Outdated
Show resolved
Hide resolved
process/process_areas/safety_analysis/guidance/safety_analysis_process_reqs.rst
Outdated
Show resolved
Hide resolved
process/process_areas/safety_analysis/guidance/safety_analysis_process_reqs.rst
Outdated
Show resolved
Hide resolved
MaximilianSoerenPollak
previously approved these changes
Jul 3, 2025
Contributor
MaximilianSoerenPollak
left a comment
MaximilianSoerenPollak
left a comment
There was a problem hiding this comment.
Looks good from my side now. 👍
PandaeDo
dismissed
MaximilianSoerenPollak’s stale review
The merge-base changed after approval.
MaximilianSoerenPollak
previously approved these changes
Jul 3, 2025
PandaeDo
dismissed
MaximilianSoerenPollak’s stale review
The merge-base changed after approval.
MaximilianSoerenPollak
previously approved these changes
Jul 4, 2025
PandaeDo
dismissed
MaximilianSoerenPollak’s stale review
The merge-base changed after approval.
Contributor
|
Is this ready for review? |
masc2023
requested changes
Jul 9, 2025
Contributor
masc2023
left a comment
masc2023
left a comment
There was a problem hiding this comment.
PR contains changes from other, already merged PRs
Contributor
|
If you upgrade docs-as-code 0.4.2 it should contain the fixes & needs you need in order to hopefully past the tests here. |
aschemmel-tech
requested changes
Jul 9, 2025
Contributor
aschemmel-tech
left a comment
aschemmel-tech
left a comment
There was a problem hiding this comment.
needs discussion and typo fixes
process/folder_templates/features/feature_name/safety_analysis/dfa.rst
Outdated
Show resolved
Hide resolved
process/folder_templates/modules/module_name/component_name/docs/safety_analysis/dfa.rst
Outdated
Show resolved
Hide resolved
process/process_areas/safety_analysis/guidance/dfa_failure_initiators.rst
Outdated
Show resolved
Hide resolved
process/process_areas/safety_analysis/guidance/dfa_failure_initiators.rst
Outdated
Show resolved
Hide resolved
process/process_areas/safety_analysis/safety_analysis_concept.rst
Outdated
Show resolved
Hide resolved
process/process_areas/safety_analysis/safety_analysis_concept.rst
Outdated
Show resolved
Hide resolved
process/process_areas/safety_analysis/safety_analysis_concept.rst
Outdated
Show resolved
Hide resolved
process/process_areas/safety_analysis/safety_analysis_concept.rst
Outdated
Show resolved
Hide resolved
process/process_areas/safety_analysis/safety_analysis_concept.rst
Outdated
Show resolved
Hide resolved
PandaeDo
force-pushed
the
vohae_safety_analysis
branch
from
9200b6d to
40a7873
Compare
masc2023
reviewed
Jul 11, 2025
process/process_areas/safety_analysis/safety_analysis_workproducts.rst
Outdated
Show resolved
Hide resolved
masc2023
reviewed
Jul 11, 2025
process/process_areas/safety_analysis/safety_analysis_workflow.rst
Outdated
Show resolved
Hide resolved
masc2023
reviewed
Jul 11, 2025
process/process_areas/safety_analysis/safety_analysis_getstrt.rst
Outdated
Show resolved
Hide resolved
masc2023
reviewed
Jul 11, 2025
masc2023
reviewed
Jul 11, 2025
masc2023
reviewed
Jul 11, 2025
masc2023
reviewed
Jul 11, 2025
process/folder_templates/modules/module_name/component_name/docs/safety_analysis/dfa.rst
Show resolved
Hide resolved
masc2023
reviewed
Jul 11, 2025
process/folder_templates/modules/module_name/component_name/docs/safety_analysis/fmea.rst
Show resolved
Hide resolved
masc2023
reviewed
Jul 11, 2025
process/process_areas/safety_analysis/safety_analysis_getstrt.rst
Outdated
Show resolved
Hide resolved
Contributor
MaximilianSoerenPollak
left a comment
MaximilianSoerenPollak
left a comment
There was a problem hiding this comment.
See comments
process/process_areas/safety_analysis/guidance/safety_analysis_process_reqs.rst
Outdated
Show resolved
Hide resolved
process/process_areas/safety_analysis/guidance/safety_analysis_process_reqs.rst
Outdated
Show resolved
Hide resolved
process/process_areas/safety_analysis/guidance/safety_analysis_process_reqs.rst
Outdated
Show resolved
Hide resolved
process/process_areas/safety_analysis/guidance/safety_analysis_process_reqs.rst
Outdated
Show resolved
Hide resolved
aschemmel-tech
requested changes
Jul 24, 2025
Contributor
aschemmel-tech
left a comment
aschemmel-tech
left a comment
There was a problem hiding this comment.
see inline comments
process/process_areas/safety_analysis/safety_analysis_roles.rst
Outdated
Show resolved
Hide resolved
process/process_areas/safety_analysis/safety_analysis_getstrt.rst
Outdated
Show resolved
Hide resolved
process/process_areas/safety_analysis/safety_analysis_getstrt.rst
Outdated
Show resolved
Hide resolved
process/process_areas/safety_analysis/safety_analysis_concept.rst
Outdated
Show resolved
Hide resolved
process/process_areas/safety_analysis/safety_analysis_concept.rst
Outdated
Show resolved
Hide resolved
process/process_areas/safety_analysis/guidance/safety_analysis_guideline.rst
Outdated
Show resolved
Hide resolved
process/process_areas/safety_analysis/guidance/safety_analysis_guideline.rst
Outdated
Show resolved
Hide resolved
process/process_areas/safety_analysis/guidance/safety_analysis_guideline.rst
Outdated
Show resolved
Hide resolved
process/process_areas/safety_analysis/guidance/safety_analysis_guideline.rst
Outdated
Show resolved
Hide resolved
process/process_areas/safety_analysis/guidance/safety_analysis_guideline.rst
Outdated
Show resolved
Hide resolved
Ref: Closes #1116
Ref: closes eclipse-score#5
Ref: closes eclipse-score#5
Ref: closes eclipse-score#5
Ref: closes eclipse-score#5
Ref: closes eclipse-score#5
PandaeDo
force-pushed
the
vohae_safety_analysis
branch
2 times, most recently
from
61d8441 to
63480a5
Compare
masc2023
reviewed
Jul 29, 2025
Contributor
There was a problem hiding this comment.
I would expect this file in a parallel folder, platform, but we can that also take in a future PR
aschemmel-tech
approved these changes
Jul 30, 2025
Contributor
aschemmel-tech
left a comment
aschemmel-tech
left a comment
There was a problem hiding this comment.
updates sufficient to merge
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: Closes #5