-
Notifications
You must be signed in to change notification settings - Fork 15
update modules for 0.5.0 release #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update modules for 0.5.0 release #21
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the integration workspace to use versioned module dependencies instead of git overrides, improving dependency management and creating a cleaner separation of concerns. The changes standardize module naming from hyphenated to underscore format (e.g., score-baselibs → score_baselibs).
Key changes:
- Migration from git_override to single_version_override for most modules, establishing versioned dependencies
- Extraction of toolchain configuration into a separate
score_toolchains.MODULE.bazelfile - Addition of a patch system for communication module to fix repository label references
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| score_toolchains.MODULE.bazel | New file extracting QNX and GCC toolchain configuration from main MODULE.bazel |
| score_modules.MODULE.bazel | Refactored to use versioned dependencies with single_version_override instead of git commits |
| patches/communication_changes.patch | Patch file fixing repository-qualified label issues and test file path resolution in communication module |
| patches/BUILD | Build file making patches directory a valid Bazel package |
| known_good.json | Updated module name from score-baselibs to score_baselibs |
| integration_test.sh | Updated module references and simplified build logic by removing persistency-specific flags |
| README.md | Updated all module references and command examples to use new naming convention |
| MODULE.bazel | Streamlined by moving toolchain configs to separate file and relocating Python setup |
| .github/workflows/test_integration.yml | Added disk cleanup steps and reorganized workflow structure |
| .bazelrc | Updated module references in build flags to new naming convention |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| #gcc toolchain for baselibs | ||
| bazel_dep(name = "score_toolchains_gcc", version = "0.5", dev_dependency = False) | ||
| gcc = use_extension("@score_toolchains_gcc//extentions:gcc.bzl", "gcc", dev_dependency = False) |
Copilot
AI
Nov 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Corrected spelling of 'extentions' to 'extensions'.
| gcc = use_extension("@score_toolchains_gcc//extentions:gcc.bzl", "gcc", dev_dependency = False) | |
| gcc = use_extension("@score_toolchains_gcc//extensions:gcc.bzl", "gcc", dev_dependency = False) |
known_good.json
Outdated
| { | ||
| "name": "score-baselibs", | ||
| "name": "score_baselibs", | ||
| "hash": "5b3a469d80c6480f633ffc789ffb1277ee89fd7f", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can this be removed?
0279d44 to
a1f3422
Compare
No description provided.