issue_2501_created_missing_drafts#2600
issue_2501_created_missing_drafts#2600attifunel wants to merge 25 commits intoeclipse-score:mainfrom
Conversation
|
|
attifunel
changed the title
|
The created documentation from the pull request is available at: docu-html |
pahmann
requested review from
PandaeDo,
aschemmel-tech,
masc2023 and
pahmann
as code owners
masc2023
left a comment
masc2023
left a comment
There was a problem hiding this comment.
All documents seems to be templates, Templates should be in process_description, Template Folder not in SCORE repo
| **2. DFA Report** | ||
| - List of the performed component DFA, pass/fail with open mitigations | ||
|
|
||
| **3. Safety Analysis Report** |
There was a problem hiding this comment.
FMEA Report, as Safety Analysis in our context is superset including DFA and FMEA
There was a problem hiding this comment.
It is already split in DFA and next subchapter Safety Analysis (i.e. FMEAs). I'd keep this structure because they're actually two analyses of very different type
There was a problem hiding this comment.
Compare here, should follow up definition, safety analysis is used as superset including DFA, therefore I woul propose, mention DFA and FMEA or only the superset term
https://eclipse-score.github.io/process_description/main/process_areas/safety_analysis/safety_analysis_concept.html
There was a problem hiding this comment.
Looking at here Platform FMEA is not planned https://eclipse-score.github.io/process_description//main/process_areas/safety_analysis/safety_analysis_workproducts.html#wp__platform_dfa
There was a problem hiding this comment.
the verification report used a template that is not compliant to https://eclipse-score.github.io/process_description//main/process_areas/verification/verification_workproducts.html#wp__verification_platform_ver_report. I will rewrite it accordingly, thanks for the notification
docs/platform_management_plan/verification_report/platform_ver_report.rst
Outdated
Show resolved
Hide resolved
docs/platform_management_plan/verification_report/platform_ver_report.rst
Outdated
Show resolved
Hide resolved
docs/platform_management_plan/verification_report/platform_ver_report.rst
Outdated
Show resolved
Hide resolved
They are not templates, but drafts. The explanatory content from the template is kept to help filling the content accordingly. |
docs/platform_management_plan/verification_report/platform_ver_report.rst
Outdated
Show resolved
Hide resolved
| **2. DFA Report** | ||
| - List of the performed component DFA, pass/fail with open mitigations | ||
|
|
||
| **3. Safety Analysis Report** |
There was a problem hiding this comment.
Compare here, should follow up definition, safety analysis is used as superset including DFA, therefore I woul propose, mention DFA and FMEA or only the superset term
https://eclipse-score.github.io/process_description/main/process_areas/safety_analysis/safety_analysis_concept.html
docs/platform_management_plan/verification_report/platform_ver_report.rst
Outdated
Show resolved
Hide resolved
docs/index.rst
Outdated
| requirements/index | ||
| modules/index | ||
| contribute/index | ||
| safety/index |
There was a problem hiding this comment.
may move safety behind PMP
There was a problem hiding this comment.
What do you mean exactly? Which folder?
There was a problem hiding this comment.
move the safety/index, that it shows up in the documentation after the PMP, may name it just safety, safety documentation is quite long
There was a problem hiding this comment.
ok, thanks, but now we have
The Platform Report should be part of Releases, I would expect for each Release, there is a own Verification Report, @aschemmel-tech , what do you think?
Please select a shorter Title Safety documentation is quite long, Releases is already a folder for the Release documentation.
docs/platform_management_plan/verification_report/platform_ver_report.rst
Outdated
Show resolved
Hide resolved
|
The proper way of linking a PR to an issue is to put the number in the Commit message (but not in the headlines): |
aschemmel-tech
left a comment
aschemmel-tech
left a comment
There was a problem hiding this comment.
See inline comments
docs/safety/platform_ver_report.rst
Outdated
There was a problem hiding this comment.
I would not see this as part of the PMP as it is not about planning. Part of Release? Safety?
There was a problem hiding this comment.
I can move it to safety
There was a problem hiding this comment.
Why moved to safety, it is about whole platform, would move it to Release
There was a problem hiding this comment.
I agree, would be better in "Release"
There was a problem hiding this comment.
https://eclipse-score.github.io/score/main/contribute/general/folder.html there is no release folder for Platform. I will create a directory in parallel to "safety". Please let me know if correct.
4 participants
Creates the documents in the safety plan which previously been "Link to WP" and their according status in "automated"
Use the folder structure as in the templates from the process_description. Missing templates for platform levels, are created from the ones from module level.
Resolves: #2501