BookmarkDoBuilder: allow fallback if page is not bookmarkable#2023
Merged
bschwarzent merged 1 commit intoreleases/26.1from Feb 23, 2026
Merged
BookmarkDoBuilder: allow fallback if page is not bookmarkable#2023bschwarzent merged 1 commit intoreleases/26.1from
bschwarzent merged 1 commit intoreleases/26.1from
Conversation
If 'persistableRequired' is true, all pages on the path should be bookmarkable. Otherwise, the bookmark creation fails. However, if 'fallbackAllowed' is true, the error can be avoided by creating a PageBookmarkDefinitionDo instead of a OutlineBookmarkDefinitionDo. By default, all pages are considered to be bookmarkable. Custom implementations of BookmarkSupport can change that by overriding isBookmarkable(). Additionally, BookmarkSupport no longer returns the wrong types when handling errors. For example, createBookmark() should return an IBookmarkDo and not the result of an error message box. In case of a handled error, the result should be null instead. (Unhandled errors still cause the promise to be rejected.) 450541
bschwarzent
force-pushed
the
features/bsh/26.1/450541_bookmarkable
branch
from
76cb67e to
95fd187
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If 'persistableRequired' is true, all pages on the path should be bookmarkable. Otherwise, the bookmark creation fails. However, if 'fallbackAllowed' is true, the error can be avoided by creating a PageBookmarkDefinitionDo instead of a OutlineBookmarkDefinitionDo.
By default, all pages are considered to be bookmarkable. Custom implementations of BookmarkSupport can change that by overriding isBookmarkable().
Additionally, BookmarkSupport no longer returns the wrong types when handling errors. For example, createBookmark() should return an IBookmarkDo and not the result of an error message box. In case of a handled error, the result should be null instead. (Unhandled errors still cause the promise to be rejected.)
450541