Skip to content

Calendar: avoid opening menu on unselected component #2028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Knicksaas merged 1 commit into from
Feb 20, 2026
+6 −1
Merged

Calendar: avoid opening menu on unselected component #2028

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion eclipse-scout-core/src/calendar/Calendar.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2010, 2025 BSI Business Systems Integration AG
* Copyright (c) 2010, 2026 BSI Business Systems Integration AG
*
* This program and the accompanying materials are made
* available under the terms of the Eclipse Public License 2.0
Expand Down Expand Up @@ -1562,6 +1562,11 @@ export class Calendar extends Widget implements CalendarModel {
if (!this.rendered || !this.attached || !this._calculateContextMenuVisible(event)) { // check needed because function is called asynchronously
return;
}
if (allowedType === Calendar.MenuType.CalendarComponent && !this.selectedComponent) {
// When right click is started outside the component and released on the component,
// no component is selected -> no context menu is opened
return;
}
let filteredMenus = menus.filter(this.menus, [allowedType], {
onlyVisible: true,
defaultMenuTypes: this.defaultMenuTypes
Expand Down