Improve font icon removal in PlainTextEncoder#2031
Merged
gabrielstalder merged 1 commit intoreleases/24.2from Feb 20, 2026
Merged
Conversation
* Adjusts PlainTextEncoder font icon regex to also remove HTML elements with font icons even if the class attribute is surrounded by other HTML attributes. The old behavior lead to an issue in a table's row icon column which displayed an ugly tooltip. * Backports part of the encoder improvements made in 25.2. See commit 931bba4. Thus, this fix is not cherry-picked to higher release. 449641
gabrielstalder
force-pushed
the
features/gst/24.2/plain_text_encoder_font_icon_removal
branch
from
5fdac8a to
d21044c
Compare
gabrielstalder
deleted the
features/gst/24.2/plain_text_encoder_font_icon_removal
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
with font icons even if the class attribute is surrounded by other HTML
attributes. The old behavior lead to an issue in a table's row icon
column which displayed an ugly tooltip.
See commit 931bba4. Thus, this fix is
not cherry-picked to higher release.
449641