-
Notifications
You must be signed in to change notification settings - Fork 6
Sskw: update column K #1861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sskw: update column K #1861
Conversation
This comment has been minimized.
This comment has been minimized.
Test Results121 tests ±0 121 ✅ ±0 12s ⏱️ -7s Results for commit c99a026. ± Comparison against base commit 8ddb161. This pull request removes 9 and adds 9 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks fine to me. I tried my best giving an useful suggestion.
return result | ||
} | ||
|
||
private def List<MultiColorContent> transformMultiColorContent( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest renaming this fn to indicate it's intention/purpose. Maybe the bug wouldn't have been introduced, if it were clear this is also used for filling column K.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it isn't used for column K, column R use it also. The different is only the condition to visualation actutorPosition
License summary❌ Not yet vetted dependencies:
Workflow run (with attached summary files): |
No description provided.