Closed
Conversation
pcdavid
added
pr: to review later
priority: low
and removed
type: ci and releng
package: forms
labels
pcdavid
force-pushed
the
pcd/enh/upgrage-lexical
branch
from
d989e59 to
af1891d
Compare
pcdavid
force-pushed
the
pcd/enh/upgrage-lexical
branch
from
af1891d to
c0a159d
Compare
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid
force-pushed
the
pcd/enh/upgrage-lexical
branch
from
c0a159d to
6378b73
Compare
pcdavid
changed the title
sbegaudeau
requested changes
Jun 9, 2024
| "@material-ui/lab": "4.0.0-alpha.61", | ||
| "@xstate/react": "1.6.3", | ||
| "lexical": "0.8.1", | ||
| "lexical": "0.15.0", |
Member
There was a problem hiding this comment.
Isn't this file missing an explicit dependency to @lexical/react? Shouldn't there be an update of the package.json of sirius-web and sirius-web-application?
Member
Author
|
Obsolete, see #6321 instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just did a quick manual tests, it seems to work as before.
But more verifications are needed to actually merge this.