[5683] Decouple library publication from a single IInput type#5973
Closed
flatombe wants to merge 1 commit intoeclipse-sirius:masterfrom
Closed
[5683] Decouple library publication from a single IInput type#5973flatombe wants to merge 1 commit intoeclipse-sirius:masterfrom
flatombe wants to merge 1 commit intoeclipse-sirius:masterfrom
Conversation
Bug: eclipse-sirius#5683 Signed-off-by: Florent Latombe <florent.latombe@obeo.fr>
Member
|
Is this PR still relevant for you now that Florian gave you some help to do what you wanted? |
sbegaudeau
requested changes
Dec 22, 2025
Member
sbegaudeau
left a comment
There was a problem hiding this comment.
In order to make this work, some mapping between the interface and the concrete type is necessary:
Error: Failures:
Error: LibraryControllerIntegrationTests.givenValidStudioProjectIdWhenPublicationMutationIsPerformedThenLibrariesArePublished:161
Expecting empty but was: [ExceptionWhileDataFetching{path=[publishLibraries], exception=java.lang.IllegalArgumentException: Cannot construct instance of `org.eclipse.sirius.web.application.library.api.IPublishLibraryInput` (no Creators, like default constructor, exist): abstract types either need to be mapped to concrete types, have custom deserializer, or contain additional type information
at [Source: UNKNOWN; byte offset: #UNKNOWN], locations=[SourceLocation{line=2, column=3}]}]
[INFO]
Error: Tests run: 563, Failures: 1, Errors: 0, Skipped: 0
Member
Look at what this PR does |
Contributor
Author
|
Closing this as Florian gave me a workaround for my original issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug: #5683
Pull request template
General purpose
What is the main goal of this pull request?
Project management
priority:andpr:labels been added to the pull request? (In case of doubt, start with the labelspriority: lowandpr: to review later)area:,difficulty:,type:)CHANGELOG.adocbeen updated to reference the relevant issues?CHANGELOG.adoc? (Including changes in the GraphQL API)CHANGELOG.adoc? For example indoc/screenshots/2022.5.0-my-new-feature.pngReview
How to test this PR?
Please describe here the various use cases to test this pull request
[ ] Has the Kiwi TCMS test suite been updated with tests for this contribution?