Skip to content

[5683] Decouple library publication from a single IInput type#5973

Closed
flatombe wants to merge 1 commit intoeclipse-sirius:masterfrom
flatombe:fla/5683
Closed

[5683] Decouple library publication from a single IInput type#5973
flatombe wants to merge 1 commit intoeclipse-sirius:masterfrom
flatombe:fla/5683

Conversation

@flatombe
Copy link
Contributor

Bug: #5683

Pull request template

General purpose

What is the main goal of this pull request?

  • Bug fixes
  • New features
  • Documentation
  • Cleanup
  • Tests
  • Build / releng

Project management

  • Has the pull request been added to the relevant project and milestone? (Only if you know that your work is part of a specific iteration such as the current one)
  • Have the priority: and pr: labels been added to the pull request? (In case of doubt, start with the labels priority: low and pr: to review later)
  • Have the relevant issues been added to the pull request?
  • Have the relevant labels been added to the issues? (area:, difficulty:, type:)
  • Have the relevant issues been added to the same project and milestone as the pull request?
  • Has the CHANGELOG.adoc been updated to reference the relevant issues?
  • Have the relevant API breaks been described in the CHANGELOG.adoc? (Including changes in the GraphQL API)
  • In case of a change with a visual impact, are there any screenshots in the CHANGELOG.adoc? For example in doc/screenshots/2022.5.0-my-new-feature.png

Review

How to test this PR?

Please describe here the various use cases to test this pull request

[ ] Has the Kiwi TCMS test suite been updated with tests for this contribution?

Bug: eclipse-sirius#5683
Signed-off-by: Florent Latombe <florent.latombe@obeo.fr>
@sbegaudeau
Copy link
Member

Is this PR still relevant for you now that Florian gave you some help to do what you wanted?

Copy link
Member

@sbegaudeau sbegaudeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In order to make this work, some mapping between the interface and the concrete type is necessary:

Error:  Failures: 
Error:    LibraryControllerIntegrationTests.givenValidStudioProjectIdWhenPublicationMutationIsPerformedThenLibrariesArePublished:161 
Expecting empty but was: [ExceptionWhileDataFetching{path=[publishLibraries], exception=java.lang.IllegalArgumentException: Cannot construct instance of `org.eclipse.sirius.web.application.library.api.IPublishLibraryInput` (no Creators, like default constructor, exist): abstract types either need to be mapped to concrete types, have custom deserializer, or contain additional type information
 at [Source: UNKNOWN; byte offset: #UNKNOWN], locations=[SourceLocation{line=2, column=3}]}]
[INFO] 
Error:  Tests run: 563, Failures: 1, Errors: 0, Skipped: 0

@gcoutable
Copy link
Member

In order to make this work, some mapping between the interface and the concrete type is necessary:

Error:  Failures: 
Error:    LibraryControllerIntegrationTests.givenValidStudioProjectIdWhenPublicationMutationIsPerformedThenLibrariesArePublished:161 
Expecting empty but was: [ExceptionWhileDataFetching{path=[publishLibraries], exception=java.lang.IllegalArgumentException: Cannot construct instance of `org.eclipse.sirius.web.application.library.api.IPublishLibraryInput` (no Creators, like default constructor, exist): abstract types either need to be mapped to concrete types, have custom deserializer, or contain additional type information
 at [Source: UNKNOWN; byte offset: #UNKNOWN], locations=[SourceLocation{line=2, column=3}]}]
[INFO] 
Error:  Tests run: 563, Failures: 1, Errors: 0, Skipped: 0

Look at what this PR does

@flatombe
Copy link
Contributor Author

Closing this as Florian gave me a workaround for my original issue.

@flatombe flatombe closed this Jan 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants