Skip to content

[6027] Improve visual feedback for diagram DnD#6031

Merged
sbegaudeau merged 1 commit intomasterfrom
pcd/enh/dnd-feedback
Jan 21, 2026
Merged

[6027] Improve visual feedback for diagram DnD#6031
sbegaudeau merged 1 commit intomasterfrom
pcd/enh/dnd-feedback

Conversation

@pcdavid
Copy link
Member

@pcdavid pcdavid commented Jan 8, 2026

Improve visual feedback when dragging a node to show which targets are compatible/valid/invalid for a drop

Bug: #6027

Capture.video.du.2026-01-09.09-29-07.mp4

Studio and instance to reproduce/test:

Pull request template

General purpose

What is the main goal of this pull request?

  • Bug fixes
  • New features
  • Documentation
  • Cleanup
  • Tests
  • Build / releng

Project management

  • Has the pull request been added to the relevant project and milestone? (Only if you know that your work is part of a specific iteration such as the current one)
  • Have the priority: and pr: labels been added to the pull request? (In case of doubt, start with the labels priority: low and pr: to review later)
  • Have the relevant issues been added to the pull request?
  • Have the relevant labels been added to the issues? (area:, difficulty:, type:)
  • Have the relevant issues been added to the same project and milestone as the pull request?
  • Has the CHANGELOG.adoc been updated to reference the relevant issues?
  • Have the relevant API breaks been described in the CHANGELOG.adoc? (Including changes in the GraphQL API)
  • In case of a change with a visual impact, are there any screenshots in the CHANGELOG.adoc? For example in doc/screenshots/2022.5.0-my-new-feature.png

Architectural decision records (ADR)

  • Does the title of the commit contributing the ADR start with [doc]?
  • Are the ADRs mentioned in the relevant section of the CHANGELOG.adoc?

Dependencies

  • Are the new / upgraded dependencies mentioned in the relevant section of the CHANGELOG.adoc?
  • Are the new dependencies justified in the CHANGELOG.adoc?

Frontend

This section is not relevant if your contribution does not come with changes to the frontend.

General purpose

  • Is the code properly tested? (Plain old JavaScript tests for business code and tests based on React Testing Library for the components)

Typing

We need to improve the typing of our code, as such, we require every contribution to come with proper TypeScript typing for both changes contributing new files and those modifying existing files.
Please ensure that the following statements are true for each file created or modified (this may require you to improve code outside of your contribution).

  • Variables have a proper type
  • Functions’ arguments have a proper type
  • Functions’ return type are specified
  • Hooks are properly typed:
    • useMutation<DATA_TYPE, VARIABLE_TYPE>(…)
    • useQuery<DATA_TYPE, VARIABLE_TYPE>(…)
    • useSubscription<DATA_TYPE, VARIABLE_TYPE>(…)
    • useMachine<CONTEXT_TYPE, EVENTS_TYPE>(…)
    • useState<STATE_TYPE>(…)
  • All components have a proper typing for their props
  • No useless optional chaining with ?. (if the GraphQL API specifies that a field cannot be null, do not treat it has potentially null for example)
  • Nullable values have a proper type (for example let diagram: Diagram | null = null;)

Backend

This section is not relevant if your contribution does not come with changes to the backend.

General purpose

  • Are all the event handlers tested?
  • Are the event processor tested?
  • Is the business code (services) tested?
  • Are diagram layout changes tested?

Architecture

  • Are data structure classes properly separated from behavioral classes?
  • Are all the relevant fields final?
  • Is any data structure mutable? If so, please write a comment indicating why
  • Are behavioral classes either stateless or side effect free?

Review

How to test this PR?

Please describe here the various use cases to test this pull request

  • Has the Kiwi TCMS test suite been updated with tests for this contribution?

@pcdavid pcdavid force-pushed the pcd/enh/dnd-feedback branch from fcda14c to 59a5b5d Compare January 9, 2026 08:27
@pcdavid pcdavid added this to the 2026.1.0 milestone Jan 9, 2026
@pcdavid pcdavid linked an issue Jan 9, 2026 that may be closed by this pull request
@pcdavid pcdavid marked this pull request as ready for review January 9, 2026 08:30
@sbegaudeau
Copy link
Member

This change seems to create an issue with the Playwright test for the drag and drop

@pcdavid pcdavid force-pushed the pcd/enh/dnd-feedback branch 4 times, most recently from 1450ef8 to 10b601b Compare January 15, 2026 08:10
Copy link
Member

@sbegaudeau sbegaudeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll merge it after the homologation phase

@sbegaudeau sbegaudeau force-pushed the pcd/enh/dnd-feedback branch from 10b601b to 0be52ff Compare January 20, 2026 09:25
Bug: #6027
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
@sbegaudeau sbegaudeau force-pushed the pcd/enh/dnd-feedback branch from 0be52ff to 0714404 Compare January 21, 2026 15:21
@sbegaudeau sbegaudeau merged commit 47dd451 into master Jan 21, 2026
4 checks passed
@sbegaudeau sbegaudeau deleted the pcd/enh/dnd-feedback branch January 21, 2026 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve visual feedback for diagram dnd

2 participants