[cleanup] Switch DeckContext from a class to a record#6358
Merged
sbegaudeau merged 1 commit intomasterfrom Apr 1, 2026
Merged
Conversation
frouene
requested changes
Mar 31, 2026
.../src/main/java/org/eclipse/sirius/components/collaborative/deck/service/DeckLaneService.java
Show resolved
Hide resolved
f1ecf78 to
34fbb45
Compare
frouene
requested changes
Mar 31, 2026
...ava/org/eclipse/sirius/components/collaborative/diagrams/handlers/EditLabelEventHandler.java
Outdated
Show resolved
Hide resolved
.../main/java/org/eclipse/sirius/components/collaborative/deck/service/DeckCreationService.java
Outdated
Show resolved
Hide resolved
34fbb45 to
a8be1c7
Compare
frouene
requested changes
Apr 1, 2026
...-deck/src/main/java/org/eclipse/sirius/components/deck/renderer/component/CardComponent.java
Show resolved
Hide resolved
a8be1c7 to
77fdc78
Compare
frouene
approved these changes
Apr 1, 2026
77fdc78 to
d61dc00
Compare
Signed-off-by: Stéphane Bégaudeau <stephane.begaudeau@obeo.fr>
d61dc00 to
0f9c2d7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stéphane Bégaudeau stephane.begaudeau@obeo.fr
Pull request template
General purpose
What is the main goal of this pull request?
Project management
priority:andpr:labels been added to the pull request? (In case of doubt, start with the labelspriority: lowandpr: to review later)area:,difficulty:,type:)CHANGELOG.adocbeen updated to reference the relevant issues?CHANGELOG.adoc? (Including changes in the GraphQL API)CHANGELOG.adoc? For example indoc/screenshots/2022.5.0-my-new-feature.pngArchitectural decision records (ADR)
[doc]?CHANGELOG.adoc?Dependencies
CHANGELOG.adoc?CHANGELOG.adoc?Frontend
This section is not relevant if your contribution does not come with changes to the frontend.
General purpose
Typing
We need to improve the typing of our code, as such, we require every contribution to come with proper TypeScript typing for both changes contributing new files and those modifying existing files.
Please ensure that the following statements are true for each file created or modified (this may require you to improve code outside of your contribution).
useMutation<DATA_TYPE, VARIABLE_TYPE>(…)useQuery<DATA_TYPE, VARIABLE_TYPE>(…)useSubscription<DATA_TYPE, VARIABLE_TYPE>(…)useMachine<CONTEXT_TYPE, EVENTS_TYPE>(…)useState<STATE_TYPE>(…)?.(if the GraphQL API specifies that a field cannot benull, do not treat it has potentiallynullfor example)let diagram: Diagram | null = null;)Backend
This section is not relevant if your contribution does not come with changes to the backend.
General purpose
Architecture
Review
How to test this PR?
Please describe here the various use cases to test this pull request