Skip to content

Comments

Pointer event support#488

Merged
spoenemann merged 2 commits intoeclipse-sprotty:masterfrom
nk-coding:master
May 13, 2025
Merged

Pointer event support#488
spoenemann merged 2 commits intoeclipse-sprotty:masterfrom
nk-coding:master

Conversation

@nk-coding
Copy link
Contributor

First half of the implementation for #485

  • adds a PointerTool, similar to the already existing MouseTool and TouchTool
  • fixes two small issues from by previous PR Initial touch support #475
    • renames two parameters for consistency (copy-paste error)
    • exports the TouchTool via index.ts (I forgot last time, sry)

Regarding the second half of #485: this will require replacing sever MouseListeners with PointerListeners to do pointer capture, which is a breaking change.
I would recommend doing this with the next major release.
I can provide a PR now, or at any in the future based on your notice.

Signed-off-by: Niklas Krieger <niklask.coding@gmail.com>
Signed-off-by: Niklas Krieger <niklask.coding@gmail.com>
Copy link
Contributor

@spoenemann spoenemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks!

@spoenemann
Copy link
Contributor

Regarding the second half of #485: this will require replacing sever MouseListeners with PointerListeners to do pointer capture, which is a breaking change.
I would recommend doing this with the next major release.
I can provide a PR now, or at any in the future based on your notice.

We should start gathering tasks and issues for the v2.0.0 milestone. We need to ensure that we don't miss other changes that should be done for the major release.

@spoenemann spoenemann merged commit a30b0a3 into eclipse-sprotty:master May 13, 2025
2 checks passed
@spoenemann spoenemann added this to the v1.5.0 milestone May 13, 2025
@nk-coding
Copy link
Contributor Author

We should start gathering tasks and issues for the v2.0.0 milestone. We need to ensure that we don't miss other changes that should be done for the major release.

in case you're interested, I have already a few things in mind
maybe I will create a discussion in the next few days with a list, you can then choose items you think are a good fit for the project (of course I'm willing to provide PRs for the items you choose)

@spoenemann
Copy link
Contributor

👍 sounds good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants