Enhance viewport animation tween function for smooth zoom and scroll#510
Open
NiklasRentzCAU wants to merge 1 commit intomasterfrom
Open
Enhance viewport animation tween function for smooth zoom and scroll#510NiklasRentzCAU wants to merge 1 commit intomasterfrom
NiklasRentzCAU wants to merge 1 commit intomasterfrom
Conversation
The old tween function for viewport animations had an exponential zoom factor curve (expected for a continuous looking zoom), but a linear interpolation for the offset. This caused animations with zoom changes to move the diagram in an unintended curve. This change fixes that behavior and incorporates the exponential zoom into the scroll offset for a consistent zoom+pan animation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old tween function for viewport animations had an exponential zoom factor curve (expected for a continuous looking zoom), but a linear interpolation for the offset. This caused animations with zoom changes to move the diagram in an unintended curve. This change fixes that behavior and incorporates the exponential zoom into the scroll offset for a consistent zoom+pan animation.
This change makes the
zoomFactorfield obsolete, it is not used anymore because mathematical simplifications in the formula do not require the log calculation anymore. I did not remove it with this PR because that would be a API-breaking change.These clips show the old and new behavior during a center and fit to screen command and during an animated zoom operation.
animation-current.mp4
animation-fixed.mp4