Skip to content

fix(rest): validate department log date as yyyy-MM-dd before Thrift call #4041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Shivamrut wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −2
Open

fix(rest): validate department log date as yyyy-MM-dd before Thrift call #4041

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...rc/main/java/org/eclipse/sw360/rest/resourceserver/department/Sw360DepartmentService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ public Set<String> getLogFileList() throws TException {
public List<String> getLogFileContentByDate(String date) throws TException {
ThriftClients thriftClients = new ThriftClients();
UserService.Iface userClient = thriftClients.makeUserClient();
if (isValidDate(date)) {
if (!isValidDate(date)) {
throw new SW360Exception("Invalid date time format, must be: yyyy-MM-dd");
}
try {
Expand All @@ -142,7 +142,7 @@ public List<String> getLogFileContentByDate(String date) throws TException {
}

private static boolean isValidDate(String dateStr) {
if (CommonUtils.isNotNullEmptyOrWhitespace(dateStr)) {
if (CommonUtils.isNullEmptyOrWhitespace(dateStr)) {
return false;
}
final String DATE_FORMAT = "yyyy-MM-dd";
Expand Down
Loading