fix: corrected the pagination counts for vendor search#4043
Open
devlopharsh wants to merge 1 commit intoeclipse-sw360:mainfrom
Open
fix: corrected the pagination counts for vendor search#4043devlopharsh wants to merge 1 commit intoeclipse-sw360:mainfrom
devlopharsh wants to merge 1 commit intoeclipse-sw360:mainfrom
Conversation
Signed-off-by: developharsh <harsh237hk@gmail.com>
Contributor
Author
|
@deo002 , Hello sir , |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #4039
Issue: #4039
Summary
The problem was that filtered vendor results were returned correctly, but
PaginationData.totalRowCountwas derived from the full CouchDB view sizeinstead of the filtered subset. As a result, the API could return a single
matching vendor while still reporting larger
totalElementsandtotalPages,which also produced incorrect
nextandlastpagination links.Changes Made
libraries/datahandler/.../DatabaseRepositoryCloudantClient.javakey,keys,startKey,endKey)totalRowCountfrom the filtered query result instead of using thefull view
totalRowsbackend/vendors/.../VendorHandlerTest.javato verify filtered search countsSuggest Reviewer
How To Test?
mvn -q test -pl rest/resource-server '-Dtest=VendorTest' '-Dbase.deploy.dir=.'mvn -q test -pl rest/resource-server '-Dtest=VendorSpecTest' '-Dbase.deploy.dir=.'GET /resource/api/vendors?page=0&page_entries=10&searchText=<matching-text>Checklist
Must: