Make ingress controller configurable in Helm charts #101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* theia-cloud-base: add `issuerprod.ingressClass` and use it in production ClusterIssuer * theia-cloud: introduce ingress helper templates and centralize annotations/ingressClassName handling * theia-cloud: add `ingress.controller`, optional `ingress.ingressClassName` and per-ingress `annotations` values
jfaltermeier
force-pushed
the
jf/ingress
branch
from
46f5b54 to
a41788f
Compare
Contributor
Author
Contributor
lucas-koehler
left a comment
lucas-koehler
left a comment
There was a problem hiding this comment.
Hi @jfaltermeier , thanks for this update! Allowing using different ingresses is certainly a big improvement :)
The changes look pretty good to me already. I have only one comment inline regarding the documentation of the ingress controller value. I believe a bit more detail what setting it implies would be helpful for adopters :)
Co-authored-by: Lucas Koehler <lkoehler@eclipsesource.com>
lucas-koehler
approved these changes
Dec 22, 2025
Contributor
lucas-koehler
left a comment
lucas-koehler
left a comment
There was a problem hiding this comment.
Pretty much looks good to me now! I think only the README in charts/theia-cloud needs to be adapted/regenerated to include the updated doc for ingress.controller
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issuerprod.ingressClassand use it in production ClusterIssueringress.controller, optionalingress.ingressClassNameand per-ingressannotationsvaluesThis change should enable users to provide their own ingress class names and annotations for the ingresses created by our helm charts.
If left empty, we may provide defaults via
_helpers.tpl. Atm this only supportsnginx, but we may add further ingress controllers and also maybe acustomoption with empty defaultsThis will act as a first step to switch away from nginx ingress controller as the default.
Related: eclipse-theia/theia-cloud#464