Skip to content

Support preference tags in settings view#16783

Merged
JonasHelming merged 3 commits intomasterfrom
support-tags-preferences
Jan 7, 2026
Merged

Support preference tags in settings view#16783
JonasHelming merged 3 commits intomasterfrom
support-tags-preferences

Conversation

@JonasHelming
Copy link
Contributor

@JonasHelming JonasHelming commented Dec 21, 2025

What it does

Implement visualization of preference tags in Theia's settings UI, similar to VS Code's behavior. Previously, preferences with tags defined in their schema (e.g., tags: ['experimental']) were not displayed in the UI, making it difficult for users to identify special preference categories.

How to test

Can also be tested in #16784

  1. Set a tag on a preference (e.g. tags: ['experimental'])
  2. Navigate to File > Preferences > Settings (or use the command palette: "Preferences: Open Settings (UI)") and look at the preference
  3. Verify that:
    • Tags appear as styled badges next to the preference name
    • Multiple tags are displayed with proper spacing
    • Tags follow the theme colors and remain readable in both light and dark themes
    • The tags don't interfere with other UI elements (prefix, suffix, modified indicators)

Breaking changes

  • This PR introduces breaking changes and requires careful review. If yes, the breaking changes section in the changelog has been updated.

Attribution

Review checklist

Reminder for reviewers

@github-project-automation github-project-automation bot moved this to Waiting on reviewers in PR Backlog Dec 21, 2025
@JonasHelming JonasHelming mentioned this pull request Dec 21, 2025
3 tasks
@ndoschek ndoschek self-requested a review December 22, 2025 15:00
Copy link
Member

@ndoschek ndoschek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @JonasHelming, this works and looks great and is a nice improvement for the settings UI! 🎉
I added two comments inline, would be great if you could have a look when you have some time.

Besides that, I noticed our settings UI does not support searching for tags, although the PreferenceSchema descriptions says so, however this should not block this PR and we can look at this in a follow up as well, from my POV.

@github-project-automation github-project-automation bot moved this from Waiting on reviewers to Waiting on author in PR Backlog Dec 22, 2025
JonasHelming and others added 2 commits December 26, 2025 23:54
…ode-renderer.ts

Co-authored-by: Nina Doschek <ndoschek@eclipsesource.com>
Commit forced formatting changes
Copy link
Member

@ndoschek ndoschek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the updates, LGTM now! 🎉

@github-project-automation github-project-automation bot moved this from Waiting on author to Needs merge in PR Backlog Jan 7, 2026
@JonasHelming JonasHelming merged commit fbbe7e8 into master Jan 7, 2026
8 of 10 checks passed
@JonasHelming JonasHelming deleted the support-tags-preferences branch January 7, 2026 15:19
@github-project-automation github-project-automation bot moved this from Needs merge to Done in PR Backlog Jan 7, 2026
@github-actions github-actions bot added this to the 1.68.0 milestone Jan 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants