Preferences: Scroll to focused item when search cleared#16992
Open
colin-grant-work wants to merge 3 commits intomasterfrom
Open
Preferences: Scroll to focused item when search cleared#16992colin-grant-work wants to merge 3 commits intomasterfrom
colin-grant-work wants to merge 3 commits intomasterfrom
Conversation
ndoschek
reviewed
Feb 16, 2026
Member
ndoschek
left a comment
There was a problem hiding this comment.
Thanks for the PR @colin-grant-work!
Unfortunately, the "scroll to focused item" feature doesn't seem to work for me, neither in the browser nor in the electron example. When I clear the search after focusing a preference, it always scrolls back to the top:
Screencast.2026-02-16.14.21.05.mp4
But maybe I am overlooking something? TIA
semicolon Co-authored-by: Nina Doschek <ndoschek@eclipsesource.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
Minor accessibility / style improvements in search editor
<span>with<button>for better semantics and keyboard access.Preserve scroll on search clear
When a user searches for a preference, focuses a result, then clears the search, the editor previously always scrolled back to the top. This did not allow users to use focus to specify their interest after the search was cleared.
Now, if the user focuses a preference row during a search and that row is still within the visible viewport when the search is cleared, the editor scrolls to that preference in the unfiltered view and selects it in the tree. The tracked focus target is reset whenever the search term changes (so refining a query doesn't carry stale state), and is ignored if the user has scrolled the focused item out of the viewport before clearing.
How to test
Follow-ups
Breaking changes
Attribution
Review checklist
nlsservice (for details, please see the Internationalization/Localization section in the Coding Guidelines)Reminder for reviewers