feat: FileService - onDidChangeFile - Implement file change buffering to deduplicate events (solution 1)#17016
Open
safisa wants to merge 1 commit intoeclipse-theia:masterfrom
Open
feat: FileService - onDidChangeFile - Implement file change buffering to deduplicate events (solution 1)#17016safisa wants to merge 1 commit intoeclipse-theia:masterfrom
safisa wants to merge 1 commit intoeclipse-theia:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
First solution to the issue below (simple with overhead: 100ms latency on every file change event + extra complexity):
Fixes: #16520
Brief summary:
Deduplicate at the FileService event emission — centralized, prevents all consumers from seeing duplicates
See comment for details:
#16520 (comment)
How to test
Follow-ups
Breaking changes
Attribution
Review checklist
nlsservice (for details, please see the Internationalization/Localization section in the Coding Guidelines)Reminder for reviewers